Repository navigation
Preserve selected profile settings over managed new-thread defaults - #44693
Merged
copyberry[bot] merged 1 commit intoSep 11, 2026
Conversation
…44693) ## Why Managed new-thread defaults could overwrite model, reasoning effort, and service tier settings from an explicitly selected profile. ## What changed - Treat effective profile settings as explicit launch choices when applying managed defaults. A profile setting for either `model` or `model_reasoning_effort` opts out of both managed values; `service_tier` remains independent. - Count a profile setting only when it supplies the highest-precedence active value, so settings shadowed by project configuration do not block defaults. ## Testing Add regression coverage for profile precedence at startup, session replacement, and background task creation, plus custom-provider profiles, service tiers, unrelated profile settings, and project settings that shadow profiles. GitOrigin-RevId: 98f036b8b7059bab8598283600dbc6967c71d3e3
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/98f036b8b7059bab8598283600dbc6967c71d3e3
branch
from
September 11, 2026 00:59
4deefe4 to
aff3e0d
Compare
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/98f036b8b7059bab8598283600dbc6967c71d3e3
branch
September 11, 2026 00:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve selected profile settings over managed new-thread defaults
Why
Managed new-thread defaults could overwrite model, reasoning effort, and service tier settings from an explicitly selected profile.
What changed
modelormodel_reasoning_effortopts out of both managed values;service_tierremains independent.Testing
Add regression coverage for profile precedence at startup, session replacement, and background task creation, plus custom-provider profiles, service tiers, unrelated profile settings, and project settings that shadow profiles.