Repository navigation
Fix Prefix property and init of Tags collection in AndOperator (#782) - #853
Merged
Merged
Conversation
leprox43
marked this pull request as draft
August 26, 2023 14:30
leprox43
marked this pull request as ready for review
August 26, 2023 14:31
martijn00
approved these changes
Aug 27, 2023
Contributor
Author
|
@martijn00 I'm sorry, but I can't complete the PR. I need to do something else? 😅 |
Contributor
|
@leprox43 you need to wait for @ebozduman to review it now. |
Contributor
Author
|
ok, thanks @martijn00 |
Contributor
|
@leprox43 can you rebase the PR to the latest master branch? |
Contributor
Author
|
@martijn00 done |
Contributor
|
@leprox43 can you use Rebase instead of Merge? |
Contributor
Author
|
@martijn00 sorry, i'll do now |
Contributor
Author
|
ok @martijn00, now i have done it |
Contributor
|
Nice work! Let's wait for @ebozduman to merge this. |
ebozduman
previously approved these changes
Aug 29, 2023
Contributor
|
Please run |
Contributor
Author
|
@ebozduman i have rebase the branch and run the tool to format AndOperator.cs file |
ebozduman
approved these changes
Aug 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minio-dotnet DON'T generate the xml node
Prefixproperty is marked asinternalinstead ofpublic.Resolve also missing initialization of
Tagproperty when using the constructor withIDictionaryobject for tags