Repository navigation
Fix inheritance and add servicecollection - #850
Conversation
0e9ce39 to
11ed7f3
Compare
|
Will do the review in during CA work hours... |
ebozduman
left a comment
ebozduman
left a comment
There was a problem hiding this comment.
Could you add some explanation/information about this PR, like what inheritance issue is fixed by this PR and why service collection is added, what is it going to help/solve etc, briefly in just one or two sentences?
|
The IMinioClient interface didn't inherit the 2 other interfaces, but the implementation did implement them. For that reason the methods in the interface were also duplicated. I've removed that. I'm now working towards a more interface based implementation of minio so that it the standard DI container of .net can use it. This is a first step towards an easier way to implement Minio. You can call AddMinio in your normal api build and resolve IMinioClient or IMinioClientFactory through DI or the service locator after that |
2 participants
@ebozduman