Skip to content

Deserialize xml content not containing namespace - #763

Merged
ebozduman merged 6 commits into
minio:masterfrom
martijn00:xmlgeneric
Apr 14, 2023
Merged

Deserialize xml content not containing namespace#763
ebozduman merged 6 commits into
minio:masterfrom
martijn00:xmlgeneric

Conversation

@martijn00

@martijn00 martijn00 commented Apr 13, 2023

Copy link
Copy Markdown
Contributor

Followup on #762

ebozduman
ebozduman suggested changes Apr 14, 2023
View reviewed changes

@ebozduman ebozduman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please notice there are 3 github actions reported for:
1- The variable 'ex' is declared but never used
2- The annotation for nullable reference types should only be used in code within a '#nullable' annotations context
3- XML comment is not placed on a valid language element

@harshavardhana harshavardhana mentioned this pull request Apr 14, 2023
Closed
ebozduman
ebozduman approved these changes Apr 14, 2023
View reviewed changes

@ebozduman ebozduman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebozduman
ebozduman merged commit 6a45116 into minio:master Apr 14, 2023
@ebozduman ebozduman mentioned this pull request Apr 17, 2023
Closed
Urantij pushed a commit to Urantij/minio-dotnet that referenced this pull request Apr 19, 2023
@martijn00 @tpatersonRBR
@ebozduman @Urantij
Deserialize xml content not containing namespace (minio#763)
955463c 
* Deserialize xml content not containing namespace

* Optimize

* Format

* dispose using streams

* Fixes

* addresses git actions/warnings

---------

Co-authored-by: Thomas Paterson 
Co-authored-by: Ersan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@ebozduman ebozduman ebozduman approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@martijn00 @ebozduman @tpatersonRBR