Repository navigation
This is a fix to set the field value before Validate() - #753
Merged
pjuarezd merged 1 commit intoMar 5, 2023
Merged
Conversation
…gned causing a `Parameter 'JWTSupplier JWT Token supplier cannot be null.'` exception. Breaking IAMAWSProvider.GetAccessCredentials See https://github.com/minio/minio-dotnet/blob/b332b78f47996ee40e2ed263b9374ad0e2663286/Minio/Credentials/IAMAWSProvider.cs#L93 This is a fix to set the field value before Validate().
harshavardhana
approved these changes
Mar 5, 2023
Urantij
pushed a commit
to Urantij/minio-dotnet
that referenced
this pull request
Apr 19, 2023
…gned causing a `Parameter 'JWTSupplier JWT Token supplier cannot be null.'` exception. (minio#753) Breaking IAMAWSProvider.GetAccessCredentials See https://github.com/minio/minio-dotnet/blob/b332b78f47996ee40e2ed263b9374ad0e2663286/Minio/Credentials/IAMAWSProvider.cs#L93 This is a fix to set the field value before Validate().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate()verifies the fieldJWTSupplieris not null before its assigned, causing aParameter 'JWTSupplier JWT Token supplier cannot be null.'exception.Breakins IAMAWSProvider.GetAccessCredentials
minio-dotnet/Minio/Credentials/IAMAWSProvider.cs
Lines 93 to 103 in b332b78
This is a fix to set the field value before Validate().