Repository navigation
* Improve testability with IMinioClient interface - #688
Merged
Merged
Conversation
luizcarlosfaria
commented
Sep 11, 2022
luizcarlosfaria
commented
Contributor
- Improving testability with IMinioClient interface
- Adding all non deprecated operations to IMinioClient
- Removing factory (With*()) operations from interface keeping on MinioClient class.
Contributor
|
Please run |
* Adding all non deprecated operations to IMinioClient * Removing factory (With*()) operations from interface mantaining on MinioClient class.
ebozduman
reviewed
Nov 29, 2022
Contributor
There was a problem hiding this comment.
-
Please rebase your branch.
-
There are some more references to
MinioClient miniowhich might also be replaced with the new interface:
1 inREADME
1 inMinio/Credentials/IAMAWSProvider.cs
3 inMinio.Examples/Cases/ListenBucketNotifications.cs,../ListIncompleteUploads.cs,../ListObjects.cs
and some more inMinio.Frunctional.Tests/FunctionalTest.cs
Member
|
@ebozduman let's take this PR and you can make those relevant changes? |
Contributor
|
Will do. |
harshavardhana
approved these changes
Dec 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.