Repository navigation
Add target based scaling support for MSSQL - #169
Merged
Merged
Conversation
Merged
6 of 13 tasks
Varshitha Bachu (bachuv)
marked this pull request as ready for review
May 17, 2023 19:25
Member
|
Quick note: I've successfully tested these changes in the Azure Functions SCv3 integration test code. |
David Justo (davidmrdavid)
left a comment
David Justo (davidmrdavid)
left a comment
Member
There was a problem hiding this comment.
Some questions, but overall looks great!
David Justo (davidmrdavid)
approved these changes
Oct 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for target based scaling. It builds upon Azure/azure-functions-durable-extension#2452. This PR is in draft mode since it hasn't been tested E2E yet.
Changes:
SqlMetricsProviderand moveGetMetricsAsync()code fromSqlScaleMonitorhereSqlTargetScaler(implementsITargetScaler)TryGetTargetScalerin SqlDurabilityProvider