Merge develop to master for 5.0.2 (#2475)

Author: AnatolyPristensky

.azure-pipelines/build-frameworks-and-docs.yml

@@ -42,7 +42,7 @@ jobs:
       scheme: 'All App Center Frameworks'
       xcodeVersion: specifyPath
       xcodeDeveloperDir: '$(XCODE_PATH)'
-      args: 'SYMROOT="$(Build.BinariesDirectory)"'
+      args: 'SYMROOT="$(Build.BinariesDirectory)" GCC_TREAT_WARNINGS_AS_ERRORS=YES SWIFT_TREAT_WARNINGS_AS_ERRORS=YES'
     timeoutInMinutes: 50
 
   - task: Xcode@5

AppCenter.podspec

@@ -1,7 +1,7 @@
 Pod::Spec.new do |s|
   s.cocoapods_version = '>= 1.10'
   s.name              = 'AppCenter'
-  s.version           = '5.0.1'
+  s.version           = '5.0.2'
 
   s.summary           = 'Visual Studio App Center is your continuous integration, delivery and learning solution for iOS and macOS apps.'
   s.description       = <<-DESC

AppCenter/AppCenter/Internals/Util/MSACUtility+File.m

@@ -25,7 +25,7 @@ + (NSURL *)createFileAtPathComponent:(NSString *)filePathComponent
                       forceOverwrite:(BOOL)forceOverwrite {
   @synchronized(self) {
     if (filePathComponent) {
-      NSURL *fileURL = [[self appCenterDirectoryURL] URLByAppendingPathComponent:filePathComponent];
+      NSURL *fileURL = [[self appCenterDirectoryURL] URLByAppendingPathComponent:filePathComponent isDirectory:NO];
 
       // Check if item already exists. We need to check this as writeToURL:atomically: can override an existing file.
       if (!forceOverwrite && [fileURL checkResourceIsReachableAndReturnError:nil]) {
@@ -89,7 +89,7 @@ + (BOOL)deleteFileAtURL:(NSURL *)fileURL {
 + (NSURL *)createDirectoryForPathComponent:(NSString *)directoryPathComponent {
   @synchronized(self) {
     if (directoryPathComponent) {
-      NSURL *subDirURL = [[self appCenterDirectoryURL] URLByAppendingPathComponent:directoryPathComponent];
+      NSURL *subDirURL = [[self appCenterDirectoryURL] URLByAppendingPathComponent:directoryPathComponent isDirectory:YES];
       BOOL success = [self createDirectoryAtURL:subDirURL];
       return success ? subDirURL : nil;
     }
@@ -100,7 +100,7 @@ + (NSURL *)createDirectoryForPathComponent:(NSString *)directoryPathComponent {
 + (NSData *)loadDataForPathComponent:(NSString *)filePathComponent {
   @synchronized(self) {
     if (filePathComponent) {
-      NSURL *fileURL = [[self appCenterDirectoryURL] URLByAppendingPathComponent:filePathComponent];
+      NSURL *fileURL = [[self appCenterDirectoryURL] URLByAppendingPathComponent:filePathComponent isDirectory:NO];
       return [NSData dataWithContentsOfURL:fileURL];
     }
     return nil;
@@ -133,15 +133,15 @@ + (BOOL)createFileAtPath:(NSString *)filePath contents:(NSData *)data attributes
 
 + (BOOL)fileExistsForPathComponent:(NSString *)filePathComponent {
   {
-    NSURL *fileURL = [[self appCenterDirectoryURL] URLByAppendingPathComponent:filePathComponent];
+    NSURL *fileURL = [[self appCenterDirectoryURL] URLByAppendingPathComponent:filePathComponent isDirectory:NO];
     return [fileURL checkResourceIsReachableAndReturnError:nil];
   }
 }
 
 + (NSURL *)fullURLForPathComponent:(NSString *)filePathComponent {
   {
     if (filePathComponent) {
-      return [[self appCenterDirectoryURL] URLByAppendingPathComponent:filePathComponent];
+      return [[self appCenterDirectoryURL] URLByAppendingPathComponent:filePathComponent isDirectory:NO];
     }
     return nil;
   }
@@ -168,9 +168,9 @@ + (NSURL *)appCenterDirectoryURL {
 
     // Use the application's bundle identifier for macOS to make sure to use separate directories for each app.
     NSString *bundleIdentifier = [NSString stringWithFormat:@"%@/", [MSAC_APP_MAIN_BUNDLE bundleIdentifier]];
-    dirURL = [[baseDirUrl URLByAppendingPathComponent:bundleIdentifier] URLByAppendingPathComponent:kMSACAppCenterBundleIdentifier];
+    dirURL = [[baseDirUrl URLByAppendingPathComponent:bundleIdentifier isDirectory:YES] URLByAppendingPathComponent:kMSACAppCenterBundleIdentifier isDirectory:YES];
 #else
-    dirURL = [baseDirUrl URLByAppendingPathComponent:kMSACAppCenterBundleIdentifier];
+    dirURL = [baseDirUrl URLByAppendingPathComponent:kMSACAppCenterBundleIdentifier isDirectory:YES];
 #endif
     [self createDirectoryAtURL:dirURL];
   });

AppCenter/AppCenter/MSACAppCenter.m

@@ -221,8 +221,8 @@ + (BOOL)isDebuggerAttached {
     name[3] = getpid();
 
     if (sysctl(name, 4, &info, &info_size, NULL, 0) == -1) {
-      NSLog(@"[MSACCrashes] ERROR: Checking for a running debugger via sysctl() "
-            @"failed.");
+      MSACLogError([MSACAppCenter logTag], @"[MSACCrashes] ERROR: Checking for a running debugger via sysctl() "
+                                           @"failed.");
       debuggerIsAttached = false;
     }
 

AppCenter/AppCenter/MSACLogger.m

@@ -8,6 +8,7 @@ @implementation MSACLogger
 static MSACLogLevel _currentLogLevel = MSACLogLevelAssert;
 static MSACLogHandler currentLogHandler;
 static BOOL _isUserDefinedLogLevel = NO;
+static dispatch_queue_t loggerDispatchQueue;
 
 MSACLogHandler const msDefaultLogHandler = ^(MSACLogMessageProvider messageProvider, MSACLogLevel logLevel, NSString *tag,
                                              __attribute__((unused)) const char *file, const char *function, uint line) {
@@ -44,6 +45,7 @@ @implementation MSACLogger
 
 + (void)initialize {
   currentLogHandler = msDefaultLogHandler;
+  loggerDispatchQueue = dispatch_queue_create("com.microsoft.appcenter.loggerQueue", DISPATCH_QUEUE_SERIAL);
 }
 
 + (MSACLogLevel)currentLogLevel {
@@ -78,12 +80,11 @@ + (void)logMessage:(MSACLogMessageProvider)messageProvider
               file:(const char *)file
           function:(const char *)function
               line:(uint)line {
-    
-    dispatch_async(dispatch_get_global_queue( DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^(void){
-        if (currentLogHandler) {
-            currentLogHandler(messageProvider, loglevel, tag, file, function, line);
-        }
+  if (currentLogHandler) {
+    dispatch_async(loggerDispatchQueue, ^{
+      currentLogHandler(messageProvider, loglevel, tag, file, function, line);
     });
+  }
 }
 
 + (BOOL)isUserDefinedLogLevel {

CHANGELOG.md

@@ -1,5 +1,15 @@
 # App Center SDK for iOS, macOS and tvOS Change Log
 
+## Version 5.0.2
+
+### App Center
+
+* **[Fix]** Fix NSLog congestion on Apple's Framework Thread.
+* **[Improvement]** Always specify `isDirectory` parameter for `[NSURL URLByAppendingPathComponent:]` for better performace.
+* **[Improvement]** Disable treating warnings as errors in code to avoid blockers when new Xcode warnings are introduced.
+
+ ___
+
 ## Version 5.0.1
 
 ### App Center

CONTRIBUTING.md

@@ -24,6 +24,7 @@ Please make sure the following is done when submitting a pull request:
 1. Make sure all tests have passed and your code is covered.
 1. If your change includes a fix or feature related to the changelog of the next release, you have to update the **CHANGELOG.md**.
 1. After creating a pull request, sign the CLA, if you haven't already.
+1. Make sure that the git history is clean, either by using squash merge of a PR or by doing amend commits during development.
 
 ### Code formatting
 

Config/Global.xcconfig

@@ -149,10 +149,6 @@ CLANG_ANALYZER_NONNULL = YES
 CLANG_ANALYZER_GCD_PERFORMANCE = YES
 CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES
 
-// Enable warnings-are-errors for all modes. Don't do this just yet.
-SWIFT_TREAT_WARNINGS_AS_ERRORS = YES
-GCC_TREAT_WARNINGS_AS_ERRORS = YES
-
 // Swift Compiler - Code Generation
 SWIFT_ENFORCE_EXCLUSIVE_ACCESS = on
 

Config/Version.xcconfig

@@ -1,2 +1,2 @@
 BUILD_NUMBER = 1
-VERSION_STRING = 5.0.1
+VERSION_STRING = 5.0.2

Documentation/iOS/AppCenter/.jazzy.yaml

@@ -5,7 +5,7 @@ sdk: iphonesimulator
 theme: ../../Themes/apple
 
 module: AppCenter
-module_version: 5.0.1
+module_version: 5.0.2
 author: Microsoft Corp
 author_url: http://www.microsoft.com