Repository navigation
Fix race condition and potential use-after-free on system distro & init port access - #41762
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The synchronization changes consistently address the identified shared-pointer races without introducing unresolved issues.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes concurrent access to WSL instance resources during termination.
Changes:
- Makes system-distro ownership atomic and uses stable local references.
- Synchronizes init-port retrieval with instance shutdown.
| File | Description |
|---|---|
WslCoreInstance.h |
Defines atomic system-distro ownership. |
WslCoreInstance.cpp |
Safely loads, clears, and retrieves shared resources. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Ben Hillis (benhillis)
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This change solves a synchronization issue between a thread accessing a running instance (via CreateLxProcess() for instance) and a thread terminating an instance.
std::shared_ptr isn't actually safe to read & write to at the time, so accesses to the system distro are wrapped in an std::atomic, and m_initChannel is now protected under m_lock
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed