Repository navigation
Style cleanup of requires\s*\( - #999
Merged
Casey Carter (CaseyCarter) merged 2 commits intoJul 7, 2020
Merged
Casey Carter (CaseyCarter) merged 2 commits into
Casey Carter (CaseyCarter) merged 2 commits into
Conversation
To consistently follow the guidelines established in microsoft#982. Fixes microsoft#982.
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jul 5, 2020
Stephan T. Lavavej (StephanTLavavej)
left a comment
Stephan T. Lavavej (StephanTLavavej)
left a comment
Member
There was a problem hiding this comment.
Looks good, one formatting nitpick that I don't really care about. Thanks for making this consistent and easier to follow! My biggest concern is that Clang/LLVM/libc++'s "NFC" convention (meaning No Functional Change) is incomprehensible to those who are unfamiliar with it, and it's impossible to search for (so much so that I had to ask on their mailing list). 😹 I think "style cleanup" is self-explanatory.
Casey Carter (CaseyCarter)
changed the title
requires\s*\(requires\s*\(
Contributor
Author
What? How is it not obvious that "NFC" stands for Near Field Communications? |
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jul 6, 2020
Miya Natsuhara (mnatsuhara)
approved these changes
Jul 6, 2020
Casey Carter (CaseyCarter)
changed the title
requires\s*\(
Contributor
Author
|
Thanks for this fix. It was absolutely ... required. 😎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To consistently follow the guidelines established in #982.
Fixes #982.