Repository navigation
Implement ranges::replace_if - #984
Merged
Casey Carter (CaseyCarter) merged 4 commits intoJul 7, 2020
Merged
Conversation
Michael Schellenberger Costa (miscco)
requested a review
from a team
as a code owner
July 3, 2020 21:18
Stephan T. Lavavej (StephanTLavavej)
requested changes
Jul 3, 2020
Stephan T. Lavavej (StephanTLavavej)
self-requested a review
July 4, 2020 09:55
Casey Carter (CaseyCarter)
suggested changes
Jul 5, 2020
Casey Carter (CaseyCarter)
approved these changes
Jul 5, 2020
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jul 5, 2020
Comment on lines
+3068
to
+3069
| _It _First, const _Se _Last, _Pr _Pred, const _Ty& _Newval, _Pj _Proj) { | ||
| // replace projected _Oldval that fulfills _Pred with _Newval in [_First, _Last) |
There was a problem hiding this comment.
I observe that there is no variable named _Oldval in this function - but this isn't confusing, so it's not worth changing to "value". No change requested.
Contributor
|
Congratulations on your first Range algorithm contribution. (Your STL bingo card must be filling up.) |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the ranges::replace_if algorithm