Repository navigation
Fix ranges test infrastructure - #979
Merged
Merged
Conversation
Michael Schellenberger Costa (miscco)
requested a review
from a team
as a code owner
July 3, 2020 08:15
Member
|
I have traditionally preferred to name test machinery differently than Standard machinery to avoid any potential for ambiguity (as I've been a huge fan of |
Casey Carter (CaseyCarter)
approved these changes
Jul 3, 2020
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jul 4, 2020
Contributor
|
Thanks for the cleanup, Michael Schellenberger Costa (@miscco)! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We get errors due to ambiguous symbols of test::iterator and std::iterator (thanks
using namespace std;)Explicitely pull in
test::iteratorandtest::rangefor good measure too