Skip to content

Fix ranges test infrastructure - #979

Merged
Casey Carter (CaseyCarter) merged 1 commit into
microsoft:masterfrom
miscco:fix_tests
Jul 7, 2020
Merged

Casey Carter (CaseyCarter) merged 1 commit into
microsoft:masterfrom
miscco:fix_tests

Conversation

@miscco

Copy link
Copy Markdown
Contributor

We get errors due to ambiguous symbols of test::iterator and std::iterator (thanks using namespace std;)
Explicitely pull in test::iterator and test::range for good measure too

@StephanTLavavej

Copy link
Copy Markdown
Member

I have traditionally preferred to name test machinery differently than Standard machinery to avoid any potential for ambiguity (as I've been a huge fan of using namespace std; in tests); MeowIterator and to a slightly lesser extent meow_iterator are clearly non-Standard. That said, I certainly defer to Casey Carter (@CaseyCarter) on ranges test conventions.

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) added the test Related to test code label Jul 3, 2020
@CaseyCarter
Casey Carter (CaseyCarter) merged commit ed5698b into microsoft:master Jul 7, 2020
@CaseyCarter

Copy link
Copy Markdown
Contributor

Thanks for the cleanup, Michael Schellenberger Costa (@miscco)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ranges C++20/23 ranges test Related to test code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants