Repository navigation
More code cleanups in stl/src - #912
Merged
Stephan T. Lavavej (StephanTLavavej) merged 21 commits intoJun 24, 2020
Merged
Stephan T. Lavavej (StephanTLavavej) merged 21 commits into
Stephan T. Lavavej (StephanTLavavej) merged 21 commits into
Conversation
Stephan T. Lavavej (StephanTLavavej)
requested a review
from a team
as a code owner
June 23, 2020 01:12
Casey Carter (CaseyCarter)
suggested changes
Jun 23, 2020
mutex.cpp: Change 0 to nullptr, avoid elaborated-type-specifier, move definition to initialization. xwctomb.cpp: Move definition to initialization, add const.
Casey Carter (CaseyCarter)
approved these changes
Jun 23, 2020
Casey Carter (CaseyCarter)
left a comment
Contributor
There was a problem hiding this comment.
Feel free to note in the commit log that any breakage from removing the double reinterpret_casts is my fault ;)
Billy O'Neal (BillyONeal)
approved these changes
Jun 23, 2020
Curtis J Bezault (cbezault)
approved these changes
Jun 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_tolower.cpp,_toupper.cpp,xwctomb.cpp.static_castfor arithmetic types.reinterpret_castfor pointers.static_castfromvoid*.mallocetc., or restoring type information after going through avoid*API. We've stylistically preferredstatic_castinstead ofreinterpret_castin these scenarios.)static_castwhenmemchr()returnsconst void*. We don't need to cast awayconst.wmemchr()at all; its return type is already correct.reinterpret_castfor_Dval*/_Fval*/_Lval*(union type-punning for floating-point). Drop thereinterpret_cast, which I believe was intended to prevent aliasing optimizations. Remove unnecessary parentheses afterwards. Useconst auto(our new convention after a cast).const_cast, required by the mismatched type ofendptr._tolower.cpp,const_castthen implicitly convert tovoid*.static_castandconst_casttolocale::facet*inlocale.cpp,wlocale.cpp,xlocale.cpp.xxxprec.h, don't macroizeldexpf/sqrtf; the UCRT provides them.0tonullptr.primitives.h, change__alignoftoalignof.__maxyet.)filesys.cpp, changewchar_t(0)(which is technically a function-style cast) toL'\0'.xstoul.cpp, remove preprocessor logic becauseunsigned longis always 32-bit on our platforms.locale.cpp,wlocale.cpp,xlocale.cpp, use default template args and name typedefs consistently.locale0.cpp.mutex.cpp, avoid an elaborated-type-specifier (presumably a relic of when this was a C translation unit).