Repository navigation
Skip /clr tests - #796
Merged
Stephan T. Lavavej (StephanTLavavej) merged 3 commits intoMay 7, 2020
Merged
Skip /clr tests#796Stephan T. Lavavej (StephanTLavavej) merged 3 commits into
Stephan T. Lavavej (StephanTLavavej) merged 3 commits into
Conversation
Stephan T. Lavavej (StephanTLavavej)
requested a review
from Curtis J Bezault (cbezault)
May 5, 2020 23:33
Stephan T. Lavavej (StephanTLavavej)
requested a review
from a team
as a code owner
May 5, 2020 23:33
Casey Carter (CaseyCarter)
approved these changes
May 5, 2020
Curtis J Bezault (cbezault)
suggested changes
May 6, 2020
Contributor
|
|
Member
Author
Yep, I understand. Before this change, |
Stephan T. Lavavej (StephanTLavavej)
requested a review
from Curtis J Bezault (cbezault)
May 6, 2020 02:54
Contributor
|
Oh woops, I misread the description as complaining that you were getting |
Curtis J Bezault (cbezault)
approved these changes
May 6, 2020
Casey Carter (CaseyCarter)
approved these changes
May 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #788. We don't yet build
/clrsupport libraries, so we shouldn't attempt to test them. (This fails on my machine, for some reason; on other machines it tests a Frankenstein combination of STL OSS and released VS code.)Additionally, this changes the Python logic to use exact matches for compiler options instead of
startswith. This doesn't make a difference given the current ordering (looking forclr:purefirst) and our current compiler options, but I believe this is more robust (given the existence of/clr:meowvariants). As before, we ignore the first character because MSVC supports-meowand/meowoption styles.This PR resolves an enormous number of test failures on my machine. Now, the test log looks like:
{ "code": "UNSUPPORTED", "elapsed": 0.0009999275207519531, "name": "std :: tests/Dev08_496675_iostream_int_reading:19", "output": "Test requires the following unavailable features: clr" }, { "code": "UNSUPPORTED", "elapsed": 0.0, "name": "std :: tests/Dev08_496675_iostream_int_reading:20", "output": "Test requires the following unavailable features: clr" }, { "code": "UNSUPPORTED", "elapsed": 0.0, "name": "std :: tests/Dev08_496675_iostream_int_reading:21", "output": "Test requires the following unavailable features: clr_pure" }, { "code": "UNSUPPORTED", "elapsed": 0.0, "name": "std :: tests/Dev08_496675_iostream_int_reading:22", "output": "Test requires the following unavailable features: clr_pure" }, { "code": "UNSUPPORTED", "elapsed": 0.0, "name": "std :: tests/Dev08_496675_iostream_int_reading:23", "output": "Test requires the following unavailable features: edg" }, { "code": "UNSUPPORTED", "elapsed": 0.0009996891021728516, "name": "std :: tests/Dev08_496675_iostream_int_reading:24", "output": "Test requires the following unavailable features: edg" }, { "code": "UNSUPPORTED", "elapsed": 0.0, "name": "std :: tests/Dev08_496675_iostream_int_reading:25", "output": "Test requires the following unavailable features: edg" },I verified that the configuration numbers for
/clr,/clr:pure, and/BEcorrespond to the lines in the test matrix.I believe this is my first 100% Python PR. 😸