Repository navigation
Clang warnings cleanup - #755
Merged
Stephan T. Lavavej (StephanTLavavej) merged 28 commits intoApr 30, 2020
Merged
Stephan T. Lavavej (StephanTLavavej) merged 28 commits into
Stephan T. Lavavej (StephanTLavavej) merged 28 commits into
Conversation
Clang-cl suppresses all warning generated in files which are present in the INCLUDE environment variable. This is undesirable to us in general, but especially when builing the test binaries.
One of our tests instantiates a _Static_partition_team with the type of _Count as a short. We store the result of a short-short division and a short-short mod operation into a short which results in a narrowing warning from int to short. This is due to short to int promotion for arithmetic binary operations.
We shouldn't be trying to find a signed value in an array of unsigned values. I chose to change the search value to an unsinged literal but casting would have worked too.
Clang complains about unused side-effects when using _STL_VERIFY.
When doing memchr optimizations in find we fallback to the standard find algorithm when the values are eligible for memchr optimization but we are constant evaluated. This can result in emitting sign-mismatch warnings which are pointless since we already do bounds checking of the search element. Just cast the search element to the type of the container's values.
We were incorrectly detecting whether or not the second byte in a 2-byte sjis glyph was valid. Also update the test to cover the full range of valid sjis 0208 characters.
We do this to avoid overriding /Od with /O2.
Currently std::terminate under _HAS_EXCEPTIONS=0 does not actually terminate the program and is therefore not noreturn. Just call _CSTD abort() directly in this case. Make _Raise [[noreturn]]
Curtis J Bezault (cbezault)
marked this pull request as draft
April 27, 2020 17:37
Casey Carter (CaseyCarter)
suggested changes
Apr 27, 2020
|
|
||
| inline void __CRTDECL terminate() noexcept { // handle exception termination | ||
| [[noreturn]] inline void __CRTDECL terminate() noexcept { // handle exception termination | ||
| _CSTD abort(); |
Contributor
There was a problem hiding this comment.
I suspect we should just unconditionally using ::terminate; instead of defining this, but I'll allow that investigating this machinery is out of scope for the change in this PR. Stephan T. Lavavej (@StephanTLavavej) mentioned this stuff is in his super-secret TODO list - should we have an issue?
There was a problem hiding this comment.
I noticed this a while ago and thought I had recorded a TODO, but didn't. (I'm migrating the TODO list to enhancement issues - 5 pages to go!) I agree that we should file an issue for this.
Co-Authored-By: Casey Carter
Stephan T. Lavavej (StephanTLavavej)
added
the
enhancement
Curtis J Bezault (cbezault)
marked this pull request as ready for review
April 27, 2020 21:57
Stephan T. Lavavej (StephanTLavavej)
requested changes
Apr 28, 2020
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Apr 29, 2020
| Mysconvert myconv(""); | ||
|
|
||
| // All ASCII and modified ASCII characters single byte characters | ||
| for (unsigned long ch = 0; ch <= 0x7f; ++ch) { |
Contributor
Author
There was a problem hiding this comment.
Hm, I guess this introduces a ton of unnecessary nul characters to be tested but still works.
Casey Carter (CaseyCarter)
approved these changes
Apr 29, 2020
Member
|
Thanks for fixing all of these warnings, and the cvt bugfix, and especially enhancing our test coverage so we remain clean in the future! I had dreamed of this but didn't know how to achieve it in the old infrastructure (as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that our code emits a fair number of warnings with
clang-clwhen building the tests. Previously we were not seeing these warnings because of the wayclangtreats "system headers".This change causes
clang-clto emit warnings on our headers and fixes up the existing warnings.I also resolved Microsoft-internal VSO-609129 " appears to have impossible condition" which was being warned about by clang.