Repository navigation
Spelling - #743
Spelling#743
Conversation
pick a pair of words which are words when a letter is removed
Stephan T. Lavavej (StephanTLavavej)
added
the
enhancement
|
These are really great catches, thanks! |
There was a problem hiding this comment.
Josh Soref (@jsoref): "The 'visual studio' change is probably the most controversial"
Me: "Whatever... you're stepping on my hilarious comment jokes!"
Stephan T. Lavavej (@StephanTLavavej): "You're damaging the correctness of this test."
Me: "HEY - I'M TRYING TO BE FUNNY OVER HERE."
Co-Authored-By: Stephan T. Lavavej
|
Stephan T. Lavavej (@StephanTLavavej): If you like them, I'll create a PR to add the action. It's really helpful. (And you can customize the dictionary, e.g. to remove |
|
|
||
|
// VSO-152213 " |
||
|
// VSO-154500 " |
||
| // C++14 LWG-2196 "Specification of is_*[copy/move]_[constructible/assignable] unclear for non-referencable types" |
There was a problem hiding this comment.
Is this a name of external issue?
There was a problem hiding this comment.
The typo is indeed in the name of https://cplusplus.github.io/LWG/issue2196 but I see no reason why we shouldn't fix it here. (The Standard consistently uses the "e" spelling.)
There was a problem hiding this comment.
Probably to help search by title. But anyway, issues with number should be searched by number instead. (And web search engines are tolerant to minor corrections, even if search by name is used)
|
Thanks again for fixing these mistakes, and congrats on your first microsoft/STL commit! 😺 |
5 participants
Most of these changes are to tests.
I'm happy to drop/adjust commits.
The
visual studiochange is probably the one most likely to be controversial. I know people like being cute and using product names, but in many projects, product names are often misspelled, so it's best to avoid whitelisting misspellings of product names. (I liked the meow and or 🐈 references.)This PR was developed using my check-spelling action.
Validation for the changes can be seen in the ✔ in spell-check.
The check-spelling configuration is derived from the version I worked on with Dustin L. Howett (MSFT) (@DHowett-MSFT) and friends for https://github.com/microsoft/terminal.