Remove _ITERATOR_DEBUG_ARRAY_OVERLOADS

[Michael Schellenberger Costa (miscco)]

This fixes #660

I ran the tests that were visibly affected on my machine. That said I am curious about the tests on other architectures

[Billy O'Neal (BillyONeal)]

Can _Array_iterator or other machinery in be pushed down now?

[Michael Schellenberger Costa (miscco)]

Can _Array_iterator or other machinery in be pushed down now?

I am unsure whether I am the best to answer that but will have a look tomorrow

[Billy O'Neal (BillyONeal)]

Can _Array_iterator or other machinery in be pushed down now?

I am unsure whether I am the best to answer that but will have a look tomorrow

I just did a grep and it looks like that thing is only used by after this change so it can be moved there, but I might have missed something.

Thanks for your contribution!

[Michael Schellenberger Costa (miscco)]

I moved _Array_const_iterator and _Array_iterator to

[Stephan T. Lavavej (StephanTLavavej)]

Looks great - thanks for the extensive test updates, moving the array iterators, and removing the now-unused _STL_VERIFY_ARRAY_SIZE. You really went above and beyond!

In fact, this change was so good, I noticed that the surrounding code in the STL was bogus in comparison. Specifically, near an IDAO removal, I noticed that we were testing _HAS_IF_CONSTEXPR within _HAS_CXX17 (which is totally unnecessary - C++17 implies if constexpr availability). I found no other occurrences throughout the STL, so I simply pushed a commit to your PR.

[Billy O'Neal (BillyONeal)]

Thanks so much :D

[Casey Carter (CaseyCarter)]

Thanks again, Michael Schellenberger Costa (@miscco)!