Skip to content

remove EDG related workaround related to bit_cast - #733

Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:masterfrom
barcharcraz:remove_bitcast_workaround
Apr 22, 2020
Merged

Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:masterfrom
barcharcraz:remove_bitcast_workaround

Conversation

@barcharcraz

@barcharcraz Charlie Barto (barcharcraz) commented Apr 21, 2020 •

Copy link
Copy Markdown
Contributor

We were working around VSO-1041044 (essentially edg not supporting our __builtin_bit_cast) now it does and it appears that's landed in 16.6 preview 2 so we can remove the workaround!

I'd like to see the CI pass in both github and VSO before merging into either, due to really needing EDG coverage.

@barcharcraz
Charlie Barto (barcharcraz) requested a review from a team as a code owner April 21, 2020 01:30

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect.

@StephanTLavavej

Copy link
Copy Markdown
Member

I'd like to see the CI pass in both github and VSO before merging into either, due to really needing EDG coverage.

This is required by the checklist for all PRs (barring exceptional circumstances like "the build is broken and something makes dual checkins temporarily impractical"): https://github.com/microsoft/STL/wiki/Checklist-For-Merging-A-Pull-Request

@barcharcraz

Copy link
Copy Markdown
Contributor Author

I'd like to see the CI pass in both github and VSO before merging into either, due to really needing EDG coverage.

This is required by the checklist for all PRs (barring exceptional circumstances like "the build is broken and something makes dual checkins temporarily impractical"): https://github.com/microsoft/STL/wiki/Checklist-For-Merging-A-Pull-Request

I want to be extra sure :D

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) added the enhancement Something can be improved label Apr 21, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were working around VSO-1020212 (essentially edg not supporting our __builtin_bit_cast) now it does and it appears that's landed in 16.6 preview 2 so we can remove the workaround!

VSO-1020212 is the "MSVC doesn't support these intrinsics" bug; VSO-1041044 - the bug for which you're actually removing workarounds in the PR - is about EDG support. Please use the correct number in the commit message ;)

@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks for removing this workaround!

fengjixuchui added a commit to fengjixuchui/STL that referenced this pull request Apr 22, 2020
Remove EDG-related workaround for bit_cast (microsoft#733)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants