Repository navigation
remove EDG related workaround related to bit_cast - #733
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
Conversation
Stephan T. Lavavej (StephanTLavavej)
left a comment
There was a problem hiding this comment.
Looks perfect.
This is required by the checklist for all PRs (barring exceptional circumstances like "the build is broken and something makes dual checkins temporarily impractical"): https://github.com/microsoft/STL/wiki/Checklist-For-Merging-A-Pull-Request |
I want to be extra sure :D |
Casey Carter (CaseyCarter)
left a comment
There was a problem hiding this comment.
We were working around VSO-1020212 (essentially edg not supporting our __builtin_bit_cast) now it does and it appears that's landed in 16.6 preview 2 so we can remove the workaround!
VSO-1020212 is the "MSVC doesn't support these intrinsics" bug; VSO-1041044 - the bug for which you're actually removing workarounds in the PR - is about EDG support. Please use the correct number in the commit message ;)
|
Thanks for removing this workaround! |
Remove EDG-related workaround for bit_cast (microsoft#733)
We were working around VSO-1041044 (essentially edg not supporting our __builtin_bit_cast) now it does and it appears that's landed in 16.6 preview 2 so we can remove the workaround!
I'd like to see the CI pass in both github and VSO before merging into either, due to really needing EDG coverage.