Repository navigation
Remove LWG-4472 comment from atomic_ref - #6358
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit intoJul 17, 2026
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Copilot started reviewing on behalf of
Jack Smith (Ninetailedcatfox)
July 12, 2026 07:08
View session
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jul 16, 2026
Stephan T. Lavavej (StephanTLavavej)
added
the
documentation
Stephan T. Lavavej (StephanTLavavej)
moved this from Initial Review
to Ready To Merge
in STL Code Reviews
Stephan T. Lavavej (StephanTLavavej)
moved this from Ready To Merge
to Merging
in STL Code Reviews
Member
|
I'm mirroring this to the MSVC-internal repo. Please notify me if any further changes are pushed, otherwise no action is required. |
Stephan T. Lavavej (StephanTLavavej)
merged commit Jul 17, 2026
a8a91c7
into
microsoft:main
49 checks passed
Member
|
Congrats on your first microsoft/STL commit! 🥇 😻 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix for LWG-4472 (
atomic_refconstruction from temporaries) has already been implemented via the = delete on the rvalue-reference constructor. This removes the tracking comment now that the issue has been accepted.Closes #6222