Repository navigation
Add Neon implementation of find_first_of - #6094
Merged
Stephan T. Lavavej (StephanTLavavej) merged 10 commits intoFeb 24, 2026
Merged
Stephan T. Lavavej (StephanTLavavej) merged 10 commits into
Stephan T. Lavavej (StephanTLavavej) merged 10 commits into
Conversation
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Feb 21, 2026
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Feb 21, 2026
Member
|
I'm mirroring this to the MSVC-internal repo. Please notify me if any further changes are pushed, otherwise no action is required. |
Stephan T. Lavavej (StephanTLavavej)
merged commit Feb 24, 2026
fbaff7a
into
microsoft:main
45 checks passed
Member
🕵️ 🦾 🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a Neon implementation of
find_first_ofusing the Shuffle approach. For_Posvariants, we select between this and the scalar bitmap approach based on thresholds.For
__std_find_first_not_of_trivial_pos_2, in the case where elements do not fit into the scalar bitmap, it can be better to use the approach ofFinding the haystack elements in the needle, so we do this.Benchmark results: