Skip to content

: remove LWG issue comment - #568

Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:masterfrom
Svido:constexpr-to_address
Feb 29, 2020
Merged

Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:masterfrom
Svido:constexpr-to_address

Conversation

@Svido

Copy link
Copy Markdown
Contributor

Fixes #531

Description

Just removing some comments.

Checklist

Be sure you've read README.md and understand the scope of this repo.

If you're unsure about a box, leave it unchecked. A maintainer will help you.

  • Identifiers in product code changes are properly _Ugly as per
    https://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
  • The STL builds successfully and all tests have passed (must be manually
    verified by an STL maintainer before automated testing is enabled on GitHub,
    leave this unchecked for initial submission).
  • These changes introduce no known ABI breaks (adding members, renaming
    members, adding virtual functions, changing whether a type is an aggregate
    or trivially copyable, etc.).
  • These changes were written from scratch using only this repository,
    the C++ Working Draft (including any cited standards), other WG21 papers
    (excluding reference implementations outside of proposed standard wording),
    and LWG issues as reference material. If they were derived from a project
    that's already listed in NOTICE.txt, that's fine, but please mention it.
    If they were derived from any other project (including Boost and libc++,
    which are not yet listed in NOTICE.txt), you must mention it here,
    so we can determine whether the license is compatible and what else needs
    to be done.

@Svido
Sven Haak (Svido) requested a review from a team as a code owner February 28, 2020 18:44
@CaseyCarter Casey Carter (CaseyCarter) added the documentation Related to documentation or comments label Feb 28, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll batch this up for merging into the Microsoft-internal repo.

@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit bb373d1 into microsoft:master Feb 29, 2020
@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks again for keeping our comments updated!

@Svido
Sven Haak (Svido) deleted the constexpr-to_address branch March 19, 2020 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Related to documentation or comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

: to_address() is now totally constexpr, so we should remove a comment

4 participants