Repository navigation
span: Implement resolution to LWG-3320 - #548
Conversation
Stephan T. Lavavej (StephanTLavavej)
linked an issue
Stephan T. Lavavej (StephanTLavavej)
left a comment
Stephan T. Lavavej (StephanTLavavej)
left a comment
There was a problem hiding this comment.
Please also regex-search for span.*const_iterator in tests/std. I see at least tests/std/tests/Dev10_709168_marking_iterators_as_checked/test.cpp and tests/std/tests/Dev11_0000000_null_forward_iterators/test.cpp . Then this should be ready to go; thanks!
f229030 to
8366ac5
Compare
In the resolution of LWG-3320 the const_iterator and const_reverse_iterator typedefs were removed together with the respective methods c{r}begin() and c{r}end().
Adopt the tests accordingly and skip the tests from libc++ until they remove them.
0581a47 to
4635e5e
Compare
|
Michael Schellenberger Costa (@miscco): Would you mind posting an |
|
The sacrifices I make ... /azp run |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 548 in repo microsoft/STL |
|
Hmmmm now to figure out where in the labyrinth to poke it... |
|
I tried granting "readers" permission to queue builds. Can you try once more? If this doesn't work I don't know if Pipelines can do that... |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 548 in repo microsoft/STL |
|
Hm, I am listed as Author and Contributor. That said I really believe that running the tests should be something that you do when the PR is actually ready not me when I think I might want to test some more. |
|
We want you (or anyone else) to be able to poke the service if your build fails due to a spurious failure like "the HTTP request to restore the vcpkg cache got unhappy". |
|
"Contributors" already had access so maybe we're toast :/. Thanks for helping test! |
Stephan T. Lavavej (StephanTLavavej)
left a comment
Stephan T. Lavavej (StephanTLavavej)
left a comment
There was a problem hiding this comment.
Looks good now, thanks! I'll port this to the Microsoft-internal repo.
|
Thanks again for this interface update - it will ship in VS 2019 16.7 Preview 1. |
4 participants
Description
In the resolution of LWG-3320 the
const_iteratorandconst_reverse_iteratortypedefs were removed together with the respective methodsc{r}begin()andc{r}end().Adopt the tests accordingly and skip the tests from libc++ until they remove them.
This addresses #542
Checklist
Be sure you've read README.md and understand the scope of this repo.
If you're unsure about a box, leave it unchecked. A maintainer will help you.
_Uglyas perhttps://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
verified by an STL maintainer before automated testing is enabled on GitHub,
leave this unchecked for initial submission).
members, adding virtual functions, changing whether a type is an aggregate
or trivially copyable, etc.).
the C++ Working Draft (including any cited standards), other WG21 papers
(excluding reference implementations outside of proposed standard wording),
and LWG issues as reference material. If they were derived from a project
that's already listed in NOTICE.txt, that's fine, but please mention it.
If they were derived from any other project (including Boost and libc++,
which are not yet listed in NOTICE.txt), you must mention it here,
so we can determine whether the license is compatible and what else needs
to be done.