Skip to content

concepts: Implement resolution to LWG-3329 - #512

Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:masterfrom
miscco:LWG_3329
Feb 29, 2020
Merged

Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:masterfrom
miscco:LWG_3329

Conversation

@miscco

@miscco Michael Schellenberger Costa (miscco) commented Feb 19, 2020 •

Copy link
Copy Markdown
Contributor

Description

Implements LWG-3329.

equality_comparable_with subsumes common_reference_with&, const remove_reference_t&> so move it up and remove the duplicated constraint

Checklist

Be sure you've read README.md and understand the scope of this repo.

If you're unsure about a box, leave it unchecked. A maintainer will help you.

  • Identifiers in product code changes are properly _Ugly as per
    https://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
  • The STL builds successfully and all tests have passed (must be manually
    verified by an STL maintainer before automated testing is enabled on GitHub,
    leave this unchecked for initial submission).
  • These changes introduce no known ABI breaks (adding members, renaming
    members, adding virtual functions, changing whether a type is an aggregate
    or trivially copyable, etc.).
  • These changes were written from scratch using only this repository,
    the C++ Working Draft (including any cited standards), other WG21 papers
    (excluding reference implementations outside of proposed standard wording),
    and LWG issues as reference material. If they were derived from a project
    that's already listed in NOTICE.txt, that's fine, but please mention it.
    If they were derived from any other project (including Boost and libc++,
    which are not yet listed in NOTICE.txt), you must mention it here,
    so we can determine whether the license is compatible and what else needs
    to be done.

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) changed the title concepts: Implement resolution to LWG 3329 concepts: Implement resolution to LWG-3329 Feb 26, 2020
@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) added the LWG Library Working Group issue label Feb 26, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - I'll port this to the Microsoft-internal repo.

@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks for implementing this LWG issue almost immediately after it was voted in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LWG Library Working Group issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LWG-3329 totally_ordered_with both directly and indirectly requires common_reference_with

3 participants