Skip to content

Remove STL workarounds for VSO-1006185 - #417

Merged
Casey Carter (CaseyCarter) merged 6 commits into
microsoft:masterfrom
CaseyCarter:vso1006185
Mar 18, 2020
Merged

Casey Carter (CaseyCarter) merged 6 commits into
microsoft:masterfrom
CaseyCarter:vso1006185

Conversation

@CaseyCarter

@CaseyCarter Casey Carter (CaseyCarter) commented Jan 9, 2020 •

Copy link
Copy Markdown
Contributor

Description

...which has been fixed for 16.6p1.

Fixes #416.

[This is a dual of internal PR MSVC-PR-222093.]

Checklist

Be sure you've read README.md and understand the scope of this repo.

If you're unsure about a box, leave it unchecked. A maintainer will help you.

  • Identifiers in product code changes are properly _Ugly as per
    https://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
  • The STL builds successfully and all tests have passed (must be manually
    verified by an STL maintainer before automated testing is enabled on GitHub,
    leave this unchecked for initial submission).
  • These changes introduce no known ABI breaks (adding members, renaming
    members, adding virtual functions, changing whether a type is an aggregate
    or trivially copyable, etc.).
  • These changes were written from scratch using only this repository,
    the C++ Working Draft (including any cited standards), other WG21 papers
    (excluding reference implementations outside of proposed standard wording),
    and LWG issues as reference material. If they were derived from a project
    that's already listed in NOTICE.txt, that's fine, but please mention it.
    If they were derived from any other project (including Boost and libc++,
    which are not yet listed in NOTICE.txt), you must mention it here,
    so we can determine whether the license is compatible and what else needs
    to be done.

...which has been fixed for 16.6p1.

Fixes microsoft#416.
@CaseyCarter
Casey Carter (CaseyCarter) requested a review from a team as a code owner January 9, 2020 21:38
@CaseyCarter Casey Carter (CaseyCarter) added the blocked Something is preventing work on this label Jan 9, 2020
@CaseyCarter

Casey Carter (CaseyCarter) commented Jan 9, 2020 •

Copy link
Copy Markdown
Contributor Author

Blocked on release of Visual Studio 2019 16.6 Preview 1.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Remember that there are workarounds in devcrt too (3 occurrences in Dev11_1140665_unique_ptr_array_conversions); depending on when we can migrate devcrt to GitHub, you'll either need to update this PR, or add Microsoft-internal test changes.

The tests hadn't made it into the OSS repo when this PR was created.
@CaseyCarter
Casey Carter (CaseyCarter) merged commit 300e856 into microsoft:master Mar 18, 2020
@CaseyCarter
Casey Carter (CaseyCarter) deleted the vso1006185 branch March 18, 2020 05:23
@CaseyCarter Casey Carter (CaseyCarter) removed their assignment Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

: Remove workarounds for VSO-1006185

3 participants