Skip to content

Fix std::filesystem::remove on ReFS targets - #407

Merged
Billy O'Neal (BillyONeal) merged 4 commits into
microsoft:masterfrom
BillyONeal:devcom-857535
Jan 6, 2020
Merged

Billy O'Neal (BillyONeal) merged 4 commits into
microsoft:masterfrom
BillyONeal:devcom-857535

Conversation

@BillyONeal

Copy link
Copy Markdown
Member

Fix std::filesystem::remove on ReFS targets by falling back to standard delete on ERROR_NOT_SUPPORTED.

Resolves DevCom-857535.

Checklist

Be sure you've read README.md and understand the scope of this repo.

If you're unsure about a box, leave it unchecked. A maintainer will help you.

  • Identifiers in product code changes are properly _Ugly as per
    https://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
  • The STL builds successfully and all tests have passed (must be manually
    verified by an STL maintainer before automated testing is enabled on GitHub,
    leave this unchecked for initial submission).
  • These changes introduce no known ABI breaks (adding members, renaming
    members, adding virtual functions, changing whether a type is an aggregate
    or trivially copyable, etc.).
  • These changes were written from scratch using only this repository,
    the C++ Working Draft (including any cited standards), other WG21 papers
    (excluding reference implementations outside of proposed standard wording),
    and LWG issues as reference material. If they were derived from a project
    that's already listed in NOTICE.txt, that's fine, but please mention it.
    If they were derived from any other project (including Boost and libc++,
    which are not yet listed in NOTICE.txt), you must mention it here,
    so we can determine whether the license is compatible and what else needs
    to be done.

…rd delete on ERROR_NOT_SUPPORTED.

Resolves DevCom-857535.
@BillyONeal
Billy O'Neal (BillyONeal) requested a review from a team as a code owner January 2, 2020 22:41
@BillyONeal

Copy link
Copy Markdown
Member Author

I manually tested this on a Windows Server machine with an ReFS volume but we have no good means of automating such a test as our tests need to work on machines without such volumes available. I tried to run our P0218R1_filesystem\test.cpp test targeting ReFS to see if there were other bits that needed to shake out; sadly that test doesn't work on ReFS because ReFS does not support hard links.

Comment thread stl/src/filesystem.cpp Outdated
Comment thread stl/src/filesystem.cpp Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants