Skip to content

Remove redundant template parameters for _XX_iter_types - #3765

Merged
Stephan T. Lavavej (StephanTLavavej) merged 11 commits into
microsoft:mainfrom
achabense:_Template_Params_Cleanup
Jun 15, 2023
Merged

Stephan T. Lavavej (StephanTLavavej) merged 11 commits into
microsoft:mainfrom
achabense:_Template_Params_Cleanup

Conversation

@achabense

Copy link
Copy Markdown
Contributor

Removes _Reference and _Const_reference for _[List/Deque/Tree/Vec/String/Flist]_iter_types.

@achabense
achabense requested a review from a team as a code owner June 12, 2023 13:07
@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) added the enhancement Something can be improved label Jun 12, 2023
@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks - I believe this should be ABI-safe.

@StephanTLavavej

Copy link
Copy Markdown
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit 45111bb into microsoft:main Jun 15, 2023
@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks for noticing and cleaning this up - ironically this machinery was meant to defend against extremely long mangled names and yet it was mentioning too many types! 😹 🧹 ✨

@achabense
achabense deleted the _Template_Params_Cleanup branch June 15, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants