Repository navigation
fix and rename _Within_limits, add tests - #3247
Merged
Stephan T. Lavavej (StephanTLavavej) merged 3 commits intoDec 6, 2022
Merged
Stephan T. Lavavej (StephanTLavavej) merged 3 commits into
Stephan T. Lavavej (StephanTLavavej) merged 3 commits into
Conversation
nicole mazzuca (strega-nil-ms)
requested a review
from a team
as a code owner
November 29, 2022 20:27
This comment was marked as resolved.
This comment was marked as resolved.
Stephan T. Lavavej (StephanTLavavej)
added
bug
Stephan T. Lavavej (StephanTLavavej)
requested changes
Nov 30, 2022
Casey Carter (CaseyCarter)
previously requested changes
Nov 30, 2022
Stephan T. Lavavej (StephanTLavavej)
requested changes
Nov 30, 2022
Contributor
Author
|
I removed the optimization change; I'll open an issue for it. |
nicole mazzuca (strega-nil-ms)
changed the title
_Within_limits, add tests
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Dec 5, 2022
Stephan T. Lavavej (StephanTLavavej)
requested a review
from Casey Carter (CaseyCarter)
December 5, 2022 19:55
Stephan T. Lavavej (StephanTLavavej)
dismissed
Casey Carter (CaseyCarter)’s stale review
December 5, 2022 22:25
Requested changes have been made
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
nicole mazzuca (strega-nil-ms)
pushed a commit
to strega-nil/stl
that referenced
this pull request
Dec 6, 2022
Casey Carter (CaseyCarter)
approved these changes
Dec 6, 2022
| } else { | ||
|
constexpr auto max_vt = numeric_limits |
||
| if constexpr (ElementType{-1} == max_vt) { | ||
| // ugly conversions :( |
Contributor
There was a problem hiding this comment.
Non-inclusive conversion shaming! (No change requested.)
Member
|
Thanks for fixing this runtime correctness regression! 🛠️ 😻 ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3244, I believe.