Repository navigation
Move barrier macros from
Merged
Stephan T. Lavavej (StephanTLavavej) merged 7 commits intoOct 24, 2022
Merged
Stephan T. Lavavej (StephanTLavavej) merged 7 commits into
Stephan T. Lavavej (StephanTLavavej) merged 7 commits into
Conversation
But I guess they should be still `#undef`ed in ``.
Strangely, some failures occured in formerly verified portions.
Stephan T. Lavavej (StephanTLavavej)
added
the
enhancement
Contributor
|
I really don't like this split of the |
Contributor
|
The lack of undefs would normally break what's in vcruntime, however, that stuff is all C only, and the header will |
Charlie Barto (barcharcraz)
approved these changes
Oct 15, 2022
Charlie Barto (barcharcraz)
left a comment
Charlie Barto (barcharcraz)
left a comment
Contributor
There was a problem hiding this comment.
I like this change; however, we should probably avoid making the stray formatting changes (approved anyways as it's trivial to revert them if they end up getting into main)
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Oct 19, 2022
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for reorganizing this atomics code! ☢️ 😹 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #3048.
Matt Stephanson (@MattStephanson) Charlie Barto (@barcharcraz)
I think we can include
locale0.cpponce this PR gets merged asI guess these macros should still be#undefed inThe separated
#undefdirectives in