Repository navigation
Change typedef to using - #3018
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit intoAug 12, 2022
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
Conversation
Mechanically replaced `(\w+) typedef (.+) (\w+);` with `using $3 $1 = $2;`. Long ago, there were compiler bugs with `using` and attributes. Those have been fixed, and we've already accumulated a few occurrences. This finishes the overhaul.
Stephan T. Lavavej (StephanTLavavej)
added
the
enhancement
Stephan T. Lavavej (StephanTLavavej)
requested a review
from a team
as a code owner
August 10, 2022 05:10
nicole mazzuca (strega-nil-ms)
approved these changes
Aug 10, 2022
Member
Author
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mechanically replaced
(\w+) typedef (.+) (\w+);withusing $3 $1 = $2;.Long long ago, we replaced every occurrence of
typedefin product code withusing, as it's more readable and consistent (alias templates must beusing). However, there were compiler bugs withusingand attributes, so we didn't replace deprecatedtypedefs. Those compiler bugs were fixed long ago, and we've already accumulated a few occurrences of deprecatedusing, e.g.:STL/stl/inc/type_traits
Lines 1097 to 1098 in 5aae678
This finishes the overhaul for product code.