Skip to content

STL: Remove !_HAS_EXACT_COMPOUND_REQUIREMENT fallback - #301

Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:masterfrom
cpplearner:master
Nov 16, 2019
Merged

Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:masterfrom
cpplearner:master

Conversation

@cpplearner

Copy link
Copy Markdown
Contributor

Description

Fixes #299.

Checklist

Be sure you've read README.md and understand the scope of this repo.

If you're unsure about a box, leave it unchecked. A maintainer will help you.

  • Identifiers in product code changes are properly _Ugly as per
    https://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
  • The STL builds successfully and all tests have passed (must be manually
    verified by an STL maintainer before automated testing is enabled on GitHub,
    leave this unchecked for initial submission).
  • These changes introduce no known ABI breaks (adding members, renaming
    members, adding virtual functions, changing whether a type is an aggregate
    or trivially copyable, etc.).
  • These changes were written from scratch using only this repository,
    the C++ Working Draft (including any cited standards), other WG21 papers
    (excluding reference implementations outside of proposed standard wording),
    and LWG issues as reference material. If they were derived from a project
    that's already listed in NOTICE.txt, that's fine, but please mention it.
    If they were derived from any other project (including Boost and libc++,
    which are not yet listed in NOTICE.txt), you must mention it here,
    so we can determine whether the license is compatible and what else needs
    to be done.

@cpplearner
S. B. Tam (cpplearner) requested a review from a team as a code owner November 15, 2019 20:47
@msftclas

Microsoft Contribution License Agreements (msftclas) commented Nov 15, 2019 •

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks correct - congratulations on submitting the first all-red PR! I'm happy to merge this contingent on tests passing. (Which they should unless there's a typo in here that I missed: we currently test concepts only with MSVC and it uses the _HAS_EXACT_COMPOUND_REQUIREMENT paths.)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I verified that there are no occurrences of this macro remaining in the product code, and I also searched our (MSVC-internal but not for much longer) test code and found no occurrences.

@StephanTLavavej

Copy link
Copy Markdown
Member

I'm porting this to our Microsoft-internal MSVC repo now, for a full build and test run.

@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit 6a96a3b into microsoft:master Nov 16, 2019
@StephanTLavavej

Copy link
Copy Markdown
Member

This passed our tests, so I've merged it for the VS 2019 16.5 Preview 2 release. Thanks again for the cleanup, and congratulations on your first commit in the STL repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

STL: !_HAS_EXACT_COMPOUND_REQUIREMENT fallbacks are unnecessary

5 participants