Skip to content

Implement LWG-3672: common_iterator::operator->() should return by value - #2907

Merged
Stephan T. Lavavej (StephanTLavavej) merged 5 commits into
microsoft:mainfrom
frederick-vs-ja:lwg-3672
Jul 28, 2022
Merged

Stephan T. Lavavej (StephanTLavavej) merged 5 commits into
microsoft:mainfrom
frederick-vs-ja:lwg-3672

Conversation

@frederick-vs-ja

Copy link
Copy Markdown
Contributor

Towards #2872.

... to fix test failures, match the existing comments, and avoid duplication.
@CaseyCarter Casey Carter (CaseyCarter) added LWG Library Working Group issue blocked Something is preventing work on this labels Jul 25, 2022
Comment thread tests/std/tests/P0896R4_common_iterator/test.cpp Outdated
@CaseyCarter Casey Carter (CaseyCarter) added the ranges C++20/23 ranges label Jul 25, 2022
Co-authored-by: Casey Carter 
@CaseyCarter Casey Carter (CaseyCarter) removed the blocked Something is preventing work on this label Jul 25, 2022
@StephanTLavavej

Copy link
Copy Markdown
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit 9974091 into microsoft:main Jul 28, 2022
@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks for implementing so many LWG issue resolutions and improving conformance! 😻 😻 😻 😻 😻 😻 😻

@frederick-vs-ja
A. Jiang (frederick-vs-ja) deleted the lwg-3672 branch July 28, 2022 03:43
Igor Zhukov (fsb4000) pushed a commit to fsb4000/STL that referenced this pull request Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LWG Library Working Group issue ranges C++20/23 ranges

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants