Repository navigation
std::getenv and std::system for UWP apps - #2850
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit intoJul 12, 2022
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
Conversation
Stephan T. Lavavej (StephanTLavavej)
added
the
enhancement
Stephan T. Lavavej (StephanTLavavej)
requested a review
from a team
as a code owner
July 7, 2022 07:28
Contributor
|
Shouldn't this be done with checking SDK version? |
Contributor
|
No, a newer SDK is not required for this to build. WACK is a validation suite and the Store always uses the latest copy of WACK. It will still build and run on SDKs older than the WACK fix. |
nicole mazzuca (strega-nil-ms)
approved these changes
Jul 7, 2022
Member
Author
|
Good question, Alex Guteniev (@AlexGuteniev). Adding to what Charles Milette (@sylveon) said, this UCRT change happened so long ago that it's always present in the UCRT headers shipping in VS 2022, so we don't need to worry about an ancient |
Member
Author
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using-declarations for makinggetenvandsystemavailable innamespace stdwere originally guarded by#ifdef _CRT_USE_WINAPI_FAMILY_DESKTOP_APPwhen the Windows App Certification Kit was very restrictive.OS-PR-1077295 "Add a bunch more CRT APIs to the WACK", merged on 2017-11-09, removed those guards from
Noticed while implementing Standard Library Modules.