Repository navigation
Enable clang-format AlignConsecutiveMacros. - #269
Merged
Stephan T. Lavavej (StephanTLavavej) merged 3 commits intoNov 7, 2019
Merged
Stephan T. Lavavej (StephanTLavavej) merged 3 commits into
Stephan T. Lavavej (StephanTLavavej) merged 3 commits into
Conversation
Stephan T. Lavavej (StephanTLavavej)
requested a review
from a team
as a code owner
November 7, 2019 02:12
Billy O'Neal (BillyONeal)
approved these changes
Nov 7, 2019
Billy O'Neal (BillyONeal)
left a comment
Member
There was a problem hiding this comment.
I am not a fan of this alignment for the same reason I'm not a fan of the 'align assignments' setting we've been using. But I care a lot less about how we format stuff than you do, so I guess this is OK.
Charlie Barto (barcharcraz)
suggested changes
Nov 7, 2019
Charlie Barto (barcharcraz)
approved these changes
Nov 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update
.clang-formatdefaults.Enable
AlignConsecutiveMacros, newly supported by clang-format 9. We often followed this style before using clang-format, and I believe that it produces generally positive changes.Apply clang-format changes.
Replace
_FITSand_NEXT_ALIGNmacros. clang-format didn't damage them, it just brought them to my attention. These macros weren't improving clarity, and the code is more systematic without them. (For the time being, I have refrained from further overhauling the metaprogramming here.)Checklist
Be sure you've read README.md and understand the scope of this repo.
If you're unsure about a box, leave it unchecked. A maintainer will help you.
_Uglyas perhttps://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
verified by an STL maintainer before automated testing is enabled on GitHub,
leave this unchecked for initial submission).
members, adding virtual functions, changing whether a type is an aggregate
or trivially copyable, etc.).
the C++ Working Draft as a reference (and any other cited standards).
If they were derived from a project that's already listed in NOTICE.txt,
that's fine, but please mention it. If they were derived from any other
project (including Boost and libc++, which are not yet listed in
NOTICE.txt), you must mention it here, so we can determine whether the
license is compatible and what else needs to be done.