Skip to content

Avoid self-move-assign of all elements in vector erasing empty - #228

Merged
Billy O'Neal (BillyONeal) merged 1 commit into
microsoft:masterfrom
BillyONeal:vector_self_move_assign
Oct 29, 2019
Merged

Billy O'Neal (BillyONeal) merged 1 commit into
microsoft:masterfrom
BillyONeal:vector_self_move_assign

Conversation

@BillyONeal

@BillyONeal Billy O'Neal (BillyONeal) commented Oct 28, 2019 •

Copy link
Copy Markdown
Member

Avoid self-move-assign of all elements in vector when erasing an empty range.

Resolves DevCom-776568.

Description

This guards the _Move_backward attempt such that some movement actually occurs.

Checklist

If you're unsure about a box, leave it unchecked. A maintainer will help you.

  • I understand README.md. I also understand that acceptance of
    community PRs will be delayed until the test and CI systems are online.
  • Identifiers in product code changes are properly _Ugly as per
    https://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
  • The STL builds successfully and all tests have passed (must be manually
    verified by an STL maintainer before CI is online, leave this unchecked for
    initial submission).
  • These changes introduce no known ABI breaks (adding members, renaming
    members, adding virtual functions, changing whether a type is an aggregate
    or trivially copyable, etc.).
  • These changes were written from scratch using only this repository and
    the C++ Working Draft as a reference (and any other cited standards).
    If they were derived from a project that's already listed in NOTICE.txt,
    that's fine, but please mention it. If they were derived from any other
    project (including Boost and libc++, which are not yet listed in
    NOTICE.txt), you must mention it here, so we can determine whether the
    license is compatible and what else needs to be done.

@BillyONeal
Billy O'Neal (BillyONeal) requested a review from a team as a code owner October 28, 2019 23:40
@CaseyCarter

Copy link
Copy Markdown
Contributor

Avoid self-move-assign of all elements in vector erasing an empty range.

This is hard to parse: maybe "when erasing"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants