Skip to content

Fix issue-218 - remove public redundancy - #219

Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits into
microsoft:masterfrom
lozinska:issue-218
Oct 25, 2019
Merged

Stephan T. Lavavej (StephanTLavavej) merged 2 commits into
microsoft:masterfrom
lozinska:issue-218

Conversation

@lozinska

@lozinska Krystyna Lopez (lozinska) commented Oct 25, 2019 •

Copy link
Copy Markdown
Contributor

Checklist

If you're unsure about a box, leave it unchecked. A maintainer will help you.

  • I understand README.md. I also understand that acceptance of
    community PRs will be delayed until the test and CI systems are online.
  • Identifiers in product code changes are properly _Ugly as per
    https://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
  • The STL builds successfully and all tests have passed (must be manually
    verified by an STL maintainer before CI is online, leave this unchecked for
    initial submission).
  • These changes introduce no known ABI breaks (adding members, renaming
    members, adding virtual functions, changing whether a type is an aggregate
    or trivially copyable, etc.).
  • These changes were written from scratch using only this repository and
    the C++ Working Draft as a reference (and any other cited standards).
    If they were derived from a project that's already listed in NOTICE.txt,
    that's fine, but please mention it. If they were derived from any other
    project (including Boost and libc++, which are not yet listed in
    NOTICE.txt), you must mention it here, so we can determine whether the
    license is compatible and what else needs to be done.

@lozinska
Krystyna Lopez (lozinska) requested a review from a team as a code owner October 25, 2019 06:41
@msftclas

Microsoft Contribution License Agreements (msftclas) commented Oct 25, 2019 •

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything here looks great, but a VSCode regular expression search for struct.*public finds 7 remaining occurrences: _Flist_simple_types in , _List_simple_types in , four copies of param_type in , and ctype_base in . Can you update those too?

@lozinska

Copy link
Copy Markdown
Contributor Author

Thank you. I will fix it

@BillyONeal Billy O'Neal (BillyONeal) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll kick off the test pass for this.

@BillyONeal

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit a69a00e into microsoft:master Oct 25, 2019
@StephanTLavavej

Copy link
Copy Markdown
Member

Thank you, and congratulations for your first merged commit!

@BillyONeal

Copy link
Copy Markdown
Member
info  run completed in 00:06:44.4094864: 21695 passed, 0 failed

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants