Repository navigation
Fix issue-218 - remove public redundancy - #219
Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits intoOct 25, 2019
Merged
Conversation
Stephan T. Lavavej (StephanTLavavej)
requested changes
Oct 25, 2019
Stephan T. Lavavej (StephanTLavavej)
left a comment
Member
There was a problem hiding this comment.
Everything here looks great, but a VSCode regular expression search for struct.*public finds 7 remaining occurrences: _Flist_simple_types in , _List_simple_types in , four copies of param_type in , and ctype_base in . Can you update those too?
Contributor
Author
|
Thank you. I will fix it |
Billy O'Neal (BillyONeal)
approved these changes
Oct 25, 2019
Billy O'Neal (BillyONeal)
left a comment
Member
There was a problem hiding this comment.
I'll kick off the test pass for this.
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Oct 25, 2019
Member
|
Thank you, and congratulations for your first merged commit! |
Member
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
If you're unsure about a box, leave it unchecked. A maintainer will help you.
community PRs will be delayed until the test and CI systems are online.
_Uglyas perhttps://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
verified by an STL maintainer before CI is online, leave this unchecked for
initial submission).
members, adding virtual functions, changing whether a type is an aggregate
or trivially copyable, etc.).
the C++ Working Draft as a reference (and any other cited standards).
If they were derived from a project that's already listed in NOTICE.txt,
that's fine, but please mention it. If they were derived from any other
project (including Boost and libc++, which are not yet listed in
NOTICE.txt), you must mention it here, so we can determine whether the
license is compatible and what else needs to be done.