Skip to content

Remove constructible_from test case - #2107

Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits into
microsoft:mainfrom
CaseyCarter:binding_fix
Aug 17, 2021
Merged

Stephan T. Lavavej (StephanTLavavej) merged 2 commits into
microsoft:mainfrom
CaseyCarter:binding_fix

Conversation

@CaseyCarter

Copy link
Copy Markdown
Contributor

... that was invalidated by WG21-P1787 "Declarations and where to find them". This is the darkest shadowy corner of a test filled with corner cases, and as such I don't feel it's worth the trouble of tracking which compiler front ends have correct behavior and which not.

Fixes VSO-1357053/AB#1357053.

... that was invalidated by WG21-P1787 "Declarations and where to find them". This is the darkest shadowy corner of a test filled with corner cases, and as such I don't feel it's worth the trouble of tracking which compiler front ends have correct behavior and which not.

Fixes VSO-1357053/AB#1357053.
@CaseyCarter Casey Carter (CaseyCarter) added the test Related to test code label Aug 9, 2021
@CaseyCarter
Casey Carter (CaseyCarter) requested a review from a team as a code owner August 9, 2021 22:29
Comment thread tests/std/tests/P0898R3_concepts/test.cpp
@StephanTLavavej

Copy link
Copy Markdown
Member

I'm mirroring this to an MSVC-internal PR. Please notify me if any further changes are pushed.

@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit 441d567 into microsoft:main Aug 17, 2021
@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks for de-squirrelifying this test coverage! 🐿️ ⛔ 😹

@CaseyCarter
Casey Carter (CaseyCarter) deleted the binding_fix branch August 19, 2021 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Related to test code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants