Repository navigation
Fix missing _CONSTEXPR20_CONTAINER on _Alloc_temporary - #1962
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit intoJun 12, 2021
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
Conversation
Michael Schellenberger Costa (miscco)
requested a review
from a team
as a code owner
June 7, 2021 14:48
Casey Carter (CaseyCarter)
approved these changes
Jun 7, 2021
Miya Natsuhara (mnatsuhara)
approved these changes
Jun 8, 2021
Member
|
Thanks for fixing this bug and improving test coverage! 🐛 💥 😺 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somebody (me) forgot to add
constexprto the storage helper.I am not really sure why this was not catched by the tests. Maybe it is because we never actually executed that code path