Repository navigation
Do size modifications after iterator transfer strategy selection - #129
Merged
Billy O'Neal (BillyONeal) merged 1 commit intoSep 24, 2019
Merged
Conversation
This was the cause of the DevCom reported bug: https://developercommunity.visualstudio.com/content/problem/739698/vc-163-listsplice-bug.html where we would choose the incorrect strategy to transfer iterators if and only if the number of transferred iterators was exactly half of the container. This change replicates internal [PR 203902](https://devdiv.visualstudio.com/DevDiv/_git/msvc/pullrequest/203902)
Casey Carter (CaseyCarter)
approved these changes
Sep 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This was the cause of the DevCom reported bug:
https://developercommunity.visualstudio.com/content/problem/739698/vc-163-listsplice-bug.html
where we would choose the incorrect strategy to transfer iterators if and only if the number of transferred iterators was exactly half of the container.
This change replicates internal PR 203902
Checklist:
(The version is important because clang-format's behavior sometimes changes.)
_Uglyas perhttps://eel.is/c++draft/lex.name#3.1 .
_Ugly.what happens to compile.
by an STL maintainer before CI is online, leave this unchecked for initial
submission).
members, adding virtual functions, changing whether a type is an aggregate or
trivially copyable, etc.). If unsure, leave this box unchecked and ask a
maintainer for help.