Repository navigation
Improve exception messages for failed casts - #1826
Merged
Manodasan Wignarajah (manodasanW) merged 1 commit intoOct 15, 2024
Merged
Manodasan Wignarajah (manodasanW) merged 1 commit into
Manodasan Wignarajah (manodasanW) merged 1 commit into
Conversation
Sergio Pedri (Sergio0694)
added
the
debugging
Sergio Pedri (Sergio0694)
requested a review
from Manodasan Wignarajah (manodasanW)
October 14, 2024 23:49
Michael Hawker (michael-hawker)
left a comment
Michael Hawker (michael-hawker)
left a comment
There was a problem hiding this comment.
Thanks Sergio, new error message looks great, would have definitely helped me right away pick up quicker on what was going on with mismatched types between XAML data template and my data structure! 🦙❤️
Manodasan Wignarajah (manodasanW)
approved these changes
Oct 15, 2024
Manodasan Wignarajah (manodasanW)
deleted the
user/sergiopedri/imporve-cast-exceptions
branch
October 15, 2024 08:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the exception message for failed
Castcalls. Fix following feedback from internal folks.