Repository navigation
Fixing issues discovered during validation - #1436
Merged
Manodasan Wignarajah (manodasanW) merged 4 commits intoJan 11, 2024
Merged
Manodasan Wignarajah (manodasanW) merged 4 commits into
Manodasan Wignarajah (manodasanW) merged 4 commits into
Conversation
Sergio Pedri (Sergio0694)
approved these changes
Jan 11, 2024
Sergio Pedri (Sergio0694)
left a comment
Sergio Pedri (Sergio0694)
left a comment
Member
There was a problem hiding this comment.
LGTM, good find! 
Member
Author
|
CI already passed: 2.0.5-prerelease.240110.22 |
Manodasan Wignarajah (manodasanW)
deleted the
manodasanw/fix_delegate_generic_instantiation2
branch
January 11, 2024 01:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous fixes to IID optimizer discovered issues where some of the generated class had incorrect IL. This was particularly in cases where the generic was known but is a custom type mapping like Nullable. This handles them by detecting if it is a generic or not before figuring out how to do a field access of the iidData field.
The generic instantiation classes for delegates were assuming they were IInspectable based when it isn't. This addresses that by fixing the vtable index.