Repository navigation
chore: backport V5.1 milestoned fixes to Stable_V5.1 - #14843
Merged
DonLakeFlyer merged 7 commits intoAug 11, 2026
Merged
Conversation
…work without native dialogs Qt.labs.platform dialogs only show when the platform theme provides a native dialog; the QtWidgets fallback was lost when QGC moved to QGuiApplication. QtQuick.Dialogs FolderDialog falls back to a QML implementation, fixing dead folder pickers (e.g. onboard log Download) on systems without native dialog support. Also fixes ClickableColor where the labs ColorDialog shadowed the QtQuick.Dialogs one, and removes stale Qt.labs imports.
An invalid QDateTime makes getUTCFullYear() return NaN, which skipped the Date Unknown branch and rendered a blank date cell. Also log the transport selection in refresh() to aid diagnosing transport issues like mavlink#14789.
Log the raw MAVLink FTP directory entries and the cached ListDirectoryWithTime capability state on every listing so a single App Log capture shows which list command was used, why, and whether the vehicle included the mtime field (debugging mavlink#14789).
"file:///" + folder produced a malformed file:////... url on non-Windows platforms, which could desync the Qt Quick dialog's breadcrumb from its folder listing (and crash on accept). Use QUrl::fromLocalFile via a new localFileToUrl helper instead. Related to mavlink#14789
From the way I look at it, the pitch indicator was inverted: Pitching down would make the bar go up, pitch up would make it go down. I've therefore inverted and now it works the same as roll, and feels right to me.
When we have more than one gimbal manager in the system, it is not clear which gimbal is which. For example: - Autopilot with internal gimbal (compid 1, gimbal device 1) - External Mavlink gimbal manager (compid 154, gimbal device 1) Previously, both of these gimbals would show as "Gimbal 1". With this change, they show up as "Gimbal 1-1" and "Gimbal 154-1".
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## Stable_V5.1 #14843 +/- ##
==============================================
Coverage ? 32.76%
==============================================
Files ? 784
Lines ? 67648
Branches ? 31342
==============================================
Hits ? 22168
Misses ? 30552
Partials ? 14928
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Contributor
Build ResultsPlatform Status
All builds passed. Pre-commit
Pre-commit hooks: 2 passed, 75 failed, 7 skipped. Test Resultslinux-coverage-integration: 37 passed, 0 skipped Code Coverage
Artifact Sizes
Updated: 2026-08-11 22:00:44 UTC • Commit: 7d85a46 • Triggered by: MacOS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks the Release V5.1 milestoned PRs merged to master that were missing from Stable_V5.1:
All cherry-picks applied cleanly.