Skip to content

feat(API): add destroyQmlApplicationEngine plugin hook (5.1) - #14805

Merged
DonLakeFlyer merged 1 commit into
mavlink:Stable_V5.1from
DonLakeFlyer:stable51-destroy-engine-hook
Aug 9, 2026
Merged

DonLakeFlyer merged 1 commit into
mavlink:Stable_V5.1from
DonLakeFlyer:stable51-destroy-engine-hook

Conversation

@DonLakeFlyer

Copy link
Copy Markdown
Contributor

Cherry-pick of #14787 to Stable_V5.1.

Verified locally on this branch: full Debug build passes.

Symmetric counterpart to createQmlApplicationEngine. Engines obtained
from the create hook are now destroyed through the plugin so it can
release per-engine state (url interceptors, etc) before the engine
goes away. QGCApplication and the QML UI test harness use the hook;
the custom-example plugin releases its url interceptor in it.
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (Stable_V5.1@249ac77). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/QGCApplication.cc 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             Stable_V5.1   #14805   +/-   ##
==============================================
  Coverage               ?   32.74%           
==============================================
  Files                  ?      784           
  Lines                  ?    67608           
  Branches               ?    31313           
==============================================
  Hits                   ?    22135           
  Misses                 ?    30579           
  Partials               ?    14894           
Flag Coverage Δ
unittests 32.74% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/API/QGCCorePlugin.cc 43.23% <100.00%> (ø)
src/API/QGCCorePlugin.h 72.72% <ø> (ø)
src/QGCApplication.cc 22.80% <0.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 249ac77...cf1067c. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Build Results

Platform Status

Platform Status Details
Linux Passed View
Windows Passed View
MacOS Passed View
Android Passed View

All builds passed.

Pre-commit

Check Status Details
pre-commit Failed (non-blocking) View

Pre-commit hooks: 0 passed, 0 failed, 0 skipped.

Test Results

linux-coverage-integration: 37 passed, 0 skipped
linux-coverage-unit: 119 passed, 0 skipped
linux-sanitizers-integration: 20 passed, 0 skipped
linux-sanitizers-unit: 119 passed, 0 skipped
Total: 295 passed, 0 skipped

Code Coverage

Coverage: 69.5%

No baseline available for comparison

Artifact Sizes

Artifact Size
QGroundControl 221.79 MB
QGroundControl-aarch64 179.36 MB
QGroundControl-installer-AMD64 137.87 MB
QGroundControl-installer-AMD64-ARM64 80.38 MB
QGroundControl-installer-ARM64 109.11 MB
QGroundControl-linux 87.04 MB
QGroundControl-mac 87.04 MB
QGroundControl-x86_64 191.58 MB
No baseline available for comparison

Updated: 2026-08-09 17:09:23 UTC • Commit: cf1067c • Triggered by: Windows

@DonLakeFlyer
DonLakeFlyer merged commit edd312c into mavlink:Stable_V5.1 Aug 9, 2026
46 checks passed
@DonLakeFlyer
DonLakeFlyer deleted the stable51-destroy-engine-hook branch August 9, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant