Skip to content

fix(Vehicle): use standard PX4 airspeed calibration value (5.1) - #14781

Merged
DonLakeFlyer merged 1 commit into
mavlink:Stable_V5.1from
DonLakeFlyer:px4-airspeed-cal-param6-5.1
Aug 8, 2026
Merged

DonLakeFlyer merged 1 commit into
mavlink:Stable_V5.1from
DonLakeFlyer:px4-airspeed-cal-param6-5.1

Conversation

@DonLakeFlyer

Copy link
Copy Markdown
Contributor

Stable_V5.1 version of #14780, replacing #14774 — thanks to @tustin-dev for identifying this and submitting the original fix!

Summary

Use the standard MAVLink value 2 for airspeed calibration in MAV_CMD_PREFLIGHT_CALIBRATION param6. PX4 deprecated 1 in Feb 2017 but still accepts both, so this is a spec-compliance cleanup: 2 matches the MAVLink spec and what PX4's own commander calibrate airspeed CLI sends.

The unit test from #14774 was dropped — see #14780 for the rationale.

MAV_CMD_PREFLIGHT_CALIBRATION param6 = 2 is the standard airspeed
calibration value. PX4 deprecated 1 in Feb 2017 but still accepts it;
2 matches the MAVLink spec and PX4's own commander CLI usage.

Replaces mavlink#14774. Thanks to @tustin-dev for the original fix.
@codecov

codecov Bot commented Aug 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (Stable_V5.1@cb8e822). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/Vehicle/Vehicle.cc 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (30.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             Stable_V5.1   #14781   +/-   ##
==============================================
  Coverage               ?   32.61%           
==============================================
  Files                  ?      784           
  Lines                  ?    67564           
  Branches               ?    31292           
==============================================
  Hits                   ?    22035           
  Misses                 ?    30666           
  Partials               ?    14863           
Flag Coverage Δ
unittests 32.61% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/Vehicle/Vehicle.cc 29.08% <0.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb8e822...735e982. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Aug 8, 2026 •

Copy link
Copy Markdown
Contributor

Build Results

Platform Status

Platform Status Details
Linux Passed View
Windows Passed View
MacOS Passed View
Android Passed View

All builds passed.

Pre-commit

Check Status Details
pre-commit Failed (non-blocking) View

Pre-commit hooks: 0 passed, 0 failed, 0 skipped.

Test Results

linux-coverage-integration: 37 passed, 0 skipped
linux-coverage-unit: 117 passed, 0 skipped
linux-sanitizers-integration: 20 passed, 0 skipped
linux-sanitizers-unit: 117 passed, 0 skipped
Total: 291 passed, 0 skipped

Code Coverage

Coverage Baseline Change
69.3% 69.4% -0.0%

Artifact Sizes

Artifact Size Δ from master
QGroundControl 221.79 MB -4.40 MB (decrease)
QGroundControl-aarch64 179.34 MB -0.01 MB (decrease)
QGroundControl-installer-AMD64 137.83 MB -0.48 MB (decrease)
QGroundControl-installer-AMD64-ARM64 80.37 MB -0.22 MB (decrease)
QGroundControl-installer-ARM64 109.11 MB -0.03 MB (decrease)
QGroundControl-linux 87.03 MB -78.74 MB (decrease)
QGroundControl-mac 87.03 MB No change
QGroundControl-x86_64 191.58 MB No change
Total size decreased by 83.87 MB

Updated: 2026-08-08 16:58:05 UTC • Commit: 735e982 • Triggered by: Android

@DonLakeFlyer
DonLakeFlyer merged commit 249ac77 into mavlink:Stable_V5.1 Aug 8, 2026
46 checks passed
@DonLakeFlyer
DonLakeFlyer deleted the px4-airspeed-cal-param6-5.1 branch August 8, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant