Repository navigation
Restart video delay - #13054
Merged
Merged
Restart video delay#13054
Conversation
This way we don't hammer the main thread with silly work
Contributor
Author
|
This need to go over to master as well |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a one-second delay before restarting a video receiver to avoid overwhelming the main thread when the video server isn't ready, plus enhanced logging and safety checks.
- Enhanced debug output in
GstVideoReceiver::startand added parameter validation in the bus message callback. - Introduced a 1 s delayed restart in
VideoManagerviaQTimer::singleShot. - Added the necessary
#include.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/VideoManager/VideoReceiver/GStreamer/GstVideoReceiver.cc | Extended startup log; added null-check and critical logging in _onBusMessage. |
| src/VideoManager/VideoManager.cc | Included QTimer; wrapped _startReceiver in a 1 s delayed lambda on stop completion. |
Collaborator
|
I thought I fixed it here but I guess timeout must be a different kind of failure |
Contributor
Author
|
Nope, that's only if there is a failure on stream setup. If the stream setup succeeds but then can't connect then the stream gets stopped and restarted. Different path. |
HTRamsey
approved these changes
Jun 21, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only restart video ofter a 1 second delay. This way we don't hammer the main thread when the video server isn't there yet on the other end of the connection.
Fix #13051