Repository navigation
Conversation
In Psalm version 6.6.0, the MissingOverrideAttribute rule was enabled for all PHP versions.
fredden
force-pushed
the
feature/psalm-upgrade-new-rules/MissingOverrideAttribute
branch
from
February 20, 2025 12:46
bac8f0a to
096e6e9
Compare
Ocramius
added
enhancement
dependencies
fredden
deleted the
feature/psalm-upgrade-new-rules/MissingOverrideAttribute
branch
February 20, 2025 13:05
Contributor
Author
|
I also wonder about the usefulness of this attribute in some of these cases. For example, when an interface defines a signature, and a class implements that method. Perhaps this should be raised with the Psalm team? Edit: it looks like this has already been raised upstream: vimeo/psalm#11305 |
Collaborator
|
Yeah, Psalm upstream is acting erratically from a maintenance PoV: let's hope it gets more stable, because ATM it looks like we're playing a game of whack-a-mole with iterations that are quickly rushed out, and lead to tons of work from our end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Psalm version 6.6.0, the MissingOverrideAttribute rule was enabled for all PHP versions.
This should fix some of the test failures in #569