Repository navigation
Move phar build (with phing) into build directory - #560
Merged
Merged
Conversation
This is the recommended approach from upstream.
Ocramius
approved these changes
Jan 30, 2025
|
Looks like this broke the release process as the phars are no longer attached to the GH releases (nor being created correctly: https://github.com/maglnet/ComposerRequireChecker/actions/runs/13185081090/job/36805168219) |
Collaborator
|
@fredden should we just revert this, perhaps? Meanwhile, note that I'm aiming at dropping |
Contributor
|
@jrfnl It has been fixed with 4.16.1. |
Collaborator
|
Thanks @bobvandevijver! |
|
Thanks @bobvandevijver and @Ocramius! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phing recommends building a phar in a different directory to where phing is installed. See phingofficial/phing#1891 (comment)
This should fix the test failure in #540.