Skip to content

Allow nikic/php-parser ^5.0.0 - #545

Closed
gazben wants to merge 12 commits into
maglnet:4.12.xfrom
gazben:fix/upgrade-php-parser
Closed

gazben wants to merge 12 commits into
maglnet:4.12.xfrom
gazben:fix/upgrade-php-parser

Conversation

@gazben

@gazben gazben commented Jul 14, 2024 •

Copy link
Copy Markdown

The nikic/php-parser package is now upgraded to 5.0. According to the changelog, this version drops the php 5 parsing and requires php 7.4.

There is automated MR regarding this topic: #484

But that MR takes a more radical approach by not allowing the v4 version.

Changelog: https://github.com/nikic/PHP-Parser/releases/tag/v5.0.0

@Ocramius

Copy link
Copy Markdown
Collaborator

This patch can only be merged if CI also runs the newest dependencies: "allowing" them is insufficient, and #484 highlights the associated failures

@gazben

gazben commented Jul 14, 2024 •

Copy link
Copy Markdown
Author

Okay, in this case I'll update the MR in the next release of vimeo/psalm is released: https://github.com/vimeo/psalm/blob/master/composer.json#L36

renovate Bot added 11 commits September 3, 2024 13:20
| datasource | package         | from    | to      |
| ---------- | --------------- | ------- | ------- |
| packagist  | phpunit/phpunit | 10.5.30 | 10.5.31 |
| datasource | package         | from   | to     |
| ---------- | --------------- | ------ | ------ |
| packagist  | phpstan/phpstan | 1.12.0 | 1.12.1 |
| datasource | package         | from    | to      |
| ---------- | --------------- | ------- | ------- |
| packagist  | phpunit/phpunit | 10.5.31 | 10.5.32 |
| datasource | package         | from   | to     |
| ---------- | --------------- | ------ | ------ |
| packagist  | phpstan/phpstan | 1.12.1 | 1.12.2 |
| datasource | package     | from   | to     |
| ---------- | ----------- | ------ | ------ |
| packagist  | vimeo/psalm | 5.25.0 | 5.26.0 |
| datasource | package         | from    | to      |
| ---------- | --------------- | ------- | ------- |
| packagist  | phpstan/phpstan | 1.12.2  | 1.12.3  |
| packagist  | phpunit/phpunit | 10.5.32 | 10.5.33 |
| datasource | package     | from   | to     |
| ---------- | ----------- | ------ | ------ |
| packagist  | vimeo/psalm | 5.26.0 | 5.26.1 |
| datasource | package         | from    | to      |
| ---------- | --------------- | ------- | ------- |
| packagist  | phpunit/phpunit | 10.5.33 | 10.5.34 |
@gazben
gazben force-pushed the fix/upgrade-php-parser branch from 39f5eca to c1b254b Compare September 14, 2024 20:10
@Ocramius

Copy link
Copy Markdown
Collaborator

Diff no longer contains "nikic/php-parser": "^5",?

@gazben

gazben commented Sep 14, 2024

Copy link
Copy Markdown
Author

I thought that with the new release of vimeo/psalm the dependency is upgraded and I rebased the branch, but I learned quickly that this is not the case. I'm waiting for this vimeo/psalm#11035

Sorry for the confusion

@Ocramius Ocramius mentioned this pull request Jan 17, 2025
@fredden

fredden commented Jan 23, 2025

Copy link
Copy Markdown
Contributor

According to vimeo/psalm#11112 (comment), vimeo/psalm "v6 will be released sometime this month." which includes support for nikic/php-parser:^5.0.

@vjik

vjik commented Jan 26, 2025

Copy link
Copy Markdown
Contributor

Psalm 6 released. Is there anything else beed for nikic/php-parser 5 support?

@gazben

gazben commented Jan 26, 2025

Copy link
Copy Markdown
Author

The problem is the roave/infection-static-analysis-plugin dependency.

@Ocramius

Copy link
Copy Markdown
Collaborator

@gazben

gazben commented Jan 27, 2025

Copy link
Copy Markdown
Author

Thanks, updated with the new release.

@Ocramius

Copy link
Copy Markdown
Collaborator

Sounds like the parser did indeed break a lot here. This run shows a ton of broken property access issues:

https://github.com/maglnet/ComposerRequireChecker/actions/runs/12984968315/job/36209988057?pr=545

@Ocramius

Ocramius commented Feb 6, 2025

Copy link
Copy Markdown
Collaborator

Done in #563

Thanks anyweay, @gazben!

@Ocramius Ocramius added duplicate enhancement dependencies Pull requests that update a dependency file labels Feb 6, 2025
@Ocramius Ocramius added this to the 4.16.0 milestone Feb 6, 2025
@Ocramius Ocramius self-assigned this Feb 6, 2025
@Ocramius Ocramius closed this Feb 6, 2025
@gazben

gazben commented Feb 6, 2025 •

Copy link
Copy Markdown
Author

Sorry I din't have time to port it. I hope I can try out the new version

@Ocramius

Ocramius commented Feb 6, 2025

Copy link
Copy Markdown
Collaborator

@gazben it's fine, it's merged + released :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file duplicate enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants