Repository navigation
Fix ReadFull must read PAGE_SIZE bytes [{0}] - #2717
Merged
Merged
Conversation
Contributor
Author
Collaborator
|
Can you provide tests which prove that you fix did fix it? |
Contributor
Author
I'm not sure how to provide tests. This is an occasional bug. The trigger reason is that failing to flush immediately after WriteStream causes ReadStream to not read the latest Page. 
|
Contributor
Author
|
WriteStream at ReadStream at |
Contributor
Author
|
When the bug occurs, bytesRead is zero. |
Collaborator
|
Even tho we can't consistently reproduce the issue out in the wild, i was able to craft a regression test which drips when your fix is not in place. Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.