Skip to content

Addresses issue of upgrading from v4.x databases in LiteDB versions 5.0.18-5.0.20 - #2499

Merged
pictos merged 3 commits into
litedb-org:masterfrom
jdtkw:master
Jun 12, 2024
Merged

pictos merged 3 commits into
litedb-org:masterfrom
jdtkw:master

Conversation

@jdtkw

@jdtkw jdtkw commented Jun 7, 2024 •

Copy link
Copy Markdown

Fixes #2494

Avoid using AesStream class when opening an older version of LiteDB database, as its imcompatible with the older versions.

@jdtkw jdtkw changed the title Avoid using AesStream class when opening an older version of LiteDB d… Addresses issue of upgrading from v4.x databases in LiteDB versions 5.0.18-5.0.20 Jun 7, 2024
@JKamsker

JKamsker commented Jun 7, 2024

Copy link
Copy Markdown
Collaborator

Can you add tests that show that the upgrade works with your changes?

@pictos pictos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, I've a minor comment to avoid this be a breaking change and with that we should be able to release it as a SR

Comment thread LiteDB/Engine/Services/RebuildService.cs Outdated
Comment thread LiteDB/Engine/Disk/StreamFactory/FileStreamFactory.cs Outdated
Comment thread LiteDB/Engine/Disk/StreamFactory/FileStreamFactory.cs Outdated

@pictos pictos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, I've a minor comment to avoid this be a breaking change and with that we should be able to release it as a SR

@pictos pictos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong button

@JKamsker

JKamsker commented Jun 7, 2024

Copy link
Copy Markdown
Collaborator

The code feels a bit odd to me but it works. I could add my tests if you allow additions by maintainers.

@JKamsker JKamsker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jdtkw

jdtkw commented Jun 10, 2024 •

Copy link
Copy Markdown
Author

The code feels a bit odd to me but it works. I could add my tests if you allow additions by maintainers.

Yeah, I went for a fix for the problem that would limit any form of adverse interaction with other code / use cases. Not 100% happy with it myself, but feel it's not going to affect normal operation once it has upgraded to to the latest format.

@jdtkw

jdtkw commented Jun 10, 2024

Copy link
Copy Markdown
Author

Can you add tests that show that the upgrade works with your changes?

Thanks for doing this.

@jdtkw
jdtkw requested a review from pictos June 10, 2024 02:24
@jdtkw

jdtkw commented Jun 12, 2024

Copy link
Copy Markdown
Author

Thanks for your contribution, I've a minor comment to avoid this be a breaking change and with that we should be able to release it as a SR

Hi @pictos - think @JKamsker already responded to the breaking change issue. I've fixed the tabs vs. spaces problem. Please let me know what else needs fixing.

Do we have a timeline on when this could be rolled into a release?

@pictos
pictos merged commit daf2c2c into litedb-org:master Jun 12, 2024
@pictos

pictos commented Jun 12, 2024

Copy link
Copy Markdown
Member

@jdtkw we will see other PRs to merge and then schedule a SR version, that should not take so long.

Thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Upgrading from Version 4 Throws LiteException: File is not encrypted as of Version 5.0.18

3 participants