Implement custom request headers for backend config by mcfedr · Pull Request #795 · kubernetes/ingress-gce

mcfedr · 2019-07-09T20:05:54Z

I've updated #572

Add e2e test based on the CDN test
Config with a struct containing the headers list
Custom resources headers are now GA

k8s-ci-robot · 2019-07-09T20:06:02Z

Hi @mcfedr. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2019-07-09T20:09:05Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2019-07-09T20:10:06Z

Welcome @mcfedr!

It looks like this is your first PR to kubernetes/ingress-gce 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-gce has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

mcfedr · 2019-07-09T20:20:54Z

cal should now be signed

mcfedr · 2019-07-09T20:23:31Z

@rramkumar1 as the previous PR by @pondohva seems to have stalled I've made the changes requested there, as well as rebasing on master

rramkumar1 · 2019-07-10T14:35:23Z

@mcfedr Thanks! We will take a look.

/ok-to-test

rramkumar1

Apologies for the delayed review, thanks for the work!

Generally LGTM, but you do need a rebase since a lot of changes have gone in before this.

mcfedr · 2019-08-07T10:51:12Z

@rramkumar1 Addressed all issues and rebased.

rramkumar1

Thanks for the work! Please close out the related issue once this is merged.

- Add e2e test - Config with a struct containing the headers list - Custom resources headers are now GA

mcfedr · 2019-08-16T08:49:45Z

@rramkumar1 Its good to go.

rramkumar1

/lgtm

rramkumar1 · 2019-08-16T13:35:41Z

/approve

k8s-ci-robot · 2019-08-16T13:37:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mcfedr, rramkumar1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [rramkumar1]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 9, 2019

k8s-ci-robot requested review from MrHohn and thockin July 9, 2019 20:06

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 9, 2019

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 9, 2019

mcfedr force-pushed the feature/customRequestHeaders branch from f524d0f to 47576dd Compare July 10, 2019 07:45

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 10, 2019

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 1, 2019

rramkumar1 reviewed Aug 6, 2019

View reviewed changes

Comment thread cmd/e2e-test/customrequestheaders_test.go Outdated

Comment thread cmd/e2e-test/customrequestheaders_test.go Outdated

Comment thread cmd/e2e-test/customrequestheaders_test.go Outdated

Comment thread pkg/backends/features/features.go Outdated

rramkumar1 mentioned this pull request Aug 6, 2019

Implement custom request headers for backend config #572

Closed

implement custom request headers for backend config

1e5e7eb

mcfedr force-pushed the feature/customRequestHeaders branch from 47576dd to fd8e104 Compare August 7, 2019 10:50

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 7, 2019

rramkumar1 approved these changes Aug 8, 2019

View reviewed changes

Comment thread pkg/backends/features/customrequestheaders_test.go Outdated

Comment thread pkg/backends/features/features_test.go Outdated

mcfedr force-pushed the feature/customRequestHeaders branch from fd8e104 to 46b9a59 Compare August 9, 2019 07:38

Fixes for custom request headers

4564cee

- Add e2e test - Config with a struct containing the headers list - Custom resources headers are now GA

mcfedr force-pushed the feature/customRequestHeaders branch from 46b9a59 to 4564cee Compare August 13, 2019 08:34

rramkumar1 reviewed Aug 16, 2019

View reviewed changes

k8s-ci-robot assigned rramkumar1 Aug 16, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2019

rramkumar1 merged commit fc87c9c into kubernetes:master Aug 16, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2019

mcfedr mentioned this pull request Aug 16, 2019

BackendConfig support for user-defined request headers #566

Closed

Conversation

mcfedr commented Jul 9, 2019

Uh oh!

k8s-ci-robot commented Jul 9, 2019

Uh oh!

k8s-ci-robot commented Jul 9, 2019

Uh oh!

k8s-ci-robot commented Jul 9, 2019

Uh oh!

mcfedr commented Jul 9, 2019

Uh oh!

mcfedr commented Jul 9, 2019

Uh oh!

rramkumar1 commented Jul 10, 2019

Uh oh!

rramkumar1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mcfedr commented Aug 7, 2019

Uh oh!

rramkumar1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mcfedr commented Aug 16, 2019

Uh oh!

rramkumar1 left a comment

Choose a reason for hiding this comment

Uh oh!

rramkumar1 commented Aug 16, 2019

Uh oh!

k8s-ci-robot commented Aug 16, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants